issue_comments

Table actions

6 rows where issue = 929518413 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

user 3

author_association 2

issue 1

  • Handle empty containers in zarr chunk checks · 6 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
1023667468 https://github.com/pydata/xarray/pull/5526#issuecomment-1023667468 https://api.github.com/repos/pydata/xarray/issues/5526 IC_kwDOAMm_X849A-0M dcherian 2448579 2022-01-27T21:46:53Z 2022-01-27T21:46:53Z MEMBER

Thanks @chrisroat Sorry this took so long to get merged

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Handle empty containers in zarr chunk checks 929518413
1003391064 https://github.com/pydata/xarray/pull/5526#issuecomment-1003391064 https://api.github.com/repos/pydata/xarray/issues/5526 IC_kwDOAMm_X847zohY chrisroat 1053153 2021-12-31T14:36:26Z 2021-12-31T14:36:26Z CONTRIBUTOR

Is this change still of potential value?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Handle empty containers in zarr chunk checks 929518413
870952879 https://github.com/pydata/xarray/pull/5526#issuecomment-870952879 https://api.github.com/repos/pydata/xarray/issues/5526 MDEyOklzc3VlQ29tbWVudDg3MDk1Mjg3OQ== jhamman 2443309 2021-06-29T22:10:51Z 2021-06-29T22:10:51Z MEMBER

Thanks @chrisroat - let's see if @rabernat or @shoyer has an opinion here then.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Handle empty containers in zarr chunk checks 929518413
870868874 https://github.com/pydata/xarray/pull/5526#issuecomment-870868874 https://api.github.com/repos/pydata/xarray/issues/5526 MDEyOklzc3VlQ29tbWVudDg3MDg2ODg3NA== chrisroat 1053153 2021-06-29T19:48:48Z 2021-06-29T19:48:48Z CONTRIBUTOR

In my original PR, I wrote:

In putting this together, I noted that open_zarr to re-read the data triggers this bug, while open_dataset(..., engine='zarr') does not. I'm not sure if my proposed fix is a band-aid, or if something in open_zarr is the real culprit.

I just want to be sure we think this is the correct fix, and there won't be any unintended consequences. I'm really not familiar with the interaction of chunks between zarr, dask, and xarray. I don't feel 100% sure this is the correct solution, though it fixes the immediate solution.

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Handle empty containers in zarr chunk checks 929518413
869831502 https://github.com/pydata/xarray/pull/5526#issuecomment-869831502 https://api.github.com/repos/pydata/xarray/issues/5526 MDEyOklzc3VlQ29tbWVudDg2OTgzMTUwMg== jhamman 2443309 2021-06-28T16:32:04Z 2021-06-28T16:32:04Z MEMBER

Thanks @chrisroat for the PR. This looks great. I do think we should add an entry in whats-new.rst though. Once that is done, I'll merge this.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Handle empty containers in zarr chunk checks 929518413
867876696 https://github.com/pydata/xarray/pull/5526#issuecomment-867876696 https://api.github.com/repos/pydata/xarray/issues/5526 MDEyOklzc3VlQ29tbWVudDg2Nzg3NjY5Ng== chrisroat 1053153 2021-06-24T18:54:23Z 2021-06-24T18:54:23Z CONTRIBUTOR

@jhamman Ready for review, though not urgent.

Mostly, I'm curious if this the right way to go about solving the linked issue, or if there is something deeper in xarray to update.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Handle empty containers in zarr chunk checks 929518413

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);