issue_comments

Table actions

8 rows where issue = 919842557 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

author_association 3

issue 1

  • Run mypy in pre-commit only in CI? · 8 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
864235819 https://github.com/pydata/xarray/pull/5468#issuecomment-864235819 https://api.github.com/repos/pydata/xarray/issues/5468 MDEyOklzc3VlQ29tbWVudDg2NDIzNTgxOQ== github-actions[bot] 41898282 2021-06-18T19:33:14Z 2021-06-18T19:33:14Z CONTRIBUTOR

Unit Test Results

0 files  ±0  0 suites  ±0   0s :stopwatch: ±0s 0 tests ±0  0 :heavy_check_mark: ±0  0 :zzz: ±0  0 :x: ±0 

Results for commit 382fe697. ± Comparison against base commit 382fe697.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Run mypy in pre-commit only in CI? 919842557
864222654 https://github.com/pydata/xarray/pull/5468#issuecomment-864222654 https://api.github.com/repos/pydata/xarray/issues/5468 MDEyOklzc3VlQ29tbWVudDg2NDIyMjY1NA== max-sixty 5635139 2021-06-18T19:01:44Z 2021-06-18T19:01:44Z MEMBER

OK let's try this, merging!

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Run mypy in pre-commit only in CI? 919842557
864222443 https://github.com/pydata/xarray/pull/5468#issuecomment-864222443 https://api.github.com/repos/pydata/xarray/issues/5468 MDEyOklzc3VlQ29tbWVudDg2NDIyMjQ0Mw== max-sixty 5635139 2021-06-18T19:01:18Z 2021-06-18T19:01:18Z MEMBER

I take this back... I just realized that #5467 is a different PR :). The previous runs cancellation is currently triggered for commits in the same branch/PR

Ah, sorry for the confusion in that case!

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Run mypy in pre-commit only in CI? 919842557
862702590 https://github.com/pydata/xarray/pull/5468#issuecomment-862702590 https://api.github.com/repos/pydata/xarray/issues/5468 MDEyOklzc3VlQ29tbWVudDg2MjcwMjU5MA== mathause 10194086 2021-06-16T20:31:06Z 2021-06-16T20:31:06Z MEMBER

This catches a numpy-based typing error in the pre-commit hook. So I think we can try this.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Run mypy in pre-commit only in CI? 919842557
861525819 https://github.com/pydata/xarray/pull/5468#issuecomment-861525819 https://api.github.com/repos/pydata/xarray/issues/5468 MDEyOklzc3VlQ29tbWVudDg2MTUyNTgxOQ== andersy005 13301940 2021-06-15T14:02:08Z 2021-06-15T14:02:08Z MEMBER

Pushing another commit to the same branch should cancel previous runs and start new runs (for the new commit). So, the fact that all runs were cancelled makes me think that it was a glitch somewhere :)

I take this back... I just realized that #5467 is a different PR :). The previous runs cancellation is currently triggered for commits in the same branch/PR

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Run mypy in pre-commit only in CI? 919842557
861522841 https://github.com/pydata/xarray/pull/5468#issuecomment-861522841 https://api.github.com/repos/pydata/xarray/issues/5468 MDEyOklzc3VlQ29tbWVudDg2MTUyMjg0MQ== andersy005 13301940 2021-06-15T13:58:45Z 2021-06-15T13:58:45Z MEMBER

@max-sixty, I skimmed through Github Action logs, but I couldn't figure out where the "cancel" command came from. I am going to speculate that it was some glitch in GitHub action.

Is it something to do with pushing another commit to #5467?

Pushing another commit to the same branch should cancel previous runs and start new runs (for the new commit). So, the fact that all runs were cancelled makes me think that it was a glitch somewhere :) 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Run mypy in pre-commit only in CI? 919842557
860244287 https://github.com/pydata/xarray/pull/5468#issuecomment-860244287 https://api.github.com/repos/pydata/xarray/issues/5468 MDEyOklzc3VlQ29tbWVudDg2MDI0NDI4Nw== max-sixty 5635139 2021-06-13T17:22:57Z 2021-06-13T17:22:57Z MEMBER

@keewis @andersy005 — could I ask (and forgive me if I'm mistaken / misremembering you as working on this) — any idea why the latest CI on this PR was cancelled? Is it something to do with pushing another commit to https://github.com/pydata/xarray/pull/5467?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Run mypy in pre-commit only in CI? 919842557
860242835 https://github.com/pydata/xarray/pull/5468#issuecomment-860242835 https://api.github.com/repos/pydata/xarray/issues/5468 MDEyOklzc3VlQ29tbWVudDg2MDI0MjgzNQ== pep8speaks 24736507 2021-06-13T17:11:39Z 2021-06-13T17:11:39Z NONE

Hello @max-sixty! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 0:1: E902 FileNotFoundError: [Errno 2] No such file or directory: 'xarray/core/computation.py'

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Run mypy in pre-commit only in CI? 919842557

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);