issue_comments

Table actions

4 rows where issue = 911513701 and user = 32069530 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 1

  • lanougue · 4 ✖

issue 1

  • bug or unclear definition of combine_attrs with xr.merge() · 4 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
861792425 https://github.com/pydata/xarray/issues/5436#issuecomment-861792425 https://api.github.com/repos/pydata/xarray/issues/5436 MDEyOklzc3VlQ29tbWVudDg2MTc5MjQyNQ== lanougue 32069530 2021-06-15T20:00:29Z 2021-06-15T20:00:29Z NONE

an additional flag like "keep_attrs" is not feasible ? It would be a boolean

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   bug or unclear definition of combine_attrs with xr.merge() 911513701
854812439 https://github.com/pydata/xarray/issues/5436#issuecomment-854812439 https://api.github.com/repos/pydata/xarray/issues/5436 MDEyOklzc3VlQ29tbWVudDg1NDgxMjQzOQ== lanougue 32069530 2021-06-04T15:24:25Z 2021-06-04T15:24:25Z NONE

I understand but I still beleive that we should be able to control separately the attrs of the final dataset and the attrs of the merged dataArray inside (whatever the way they are passed to the merge function)

Thanks for the pint-xarray suggestion! I didn't know about it. I will look into it.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   bug or unclear definition of combine_attrs with xr.merge() 911513701
854768921 https://github.com/pydata/xarray/issues/5436#issuecomment-854768921 https://api.github.com/repos/pydata/xarray/issues/5436 MDEyOklzc3VlQ29tbWVudDg1NDc2ODkyMQ== lanougue 32069530 2021-06-04T14:27:07Z 2021-06-04T14:27:07Z NONE

Ok, I understand your point of view. My question (or what you think could be a bug) thus becomes: why "drop" option removes attrs from the variables in the merged dataset while "drop_conflicts" and "override" keep them ?

It should thus be some way to say the merging to keep or not the attrs of each variables in the final dataset. (I do not understand your comment: how to keep the units on the data instead of in the attributes ?)

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   bug or unclear definition of combine_attrs with xr.merge() 911513701
854739959 https://github.com/pydata/xarray/issues/5436#issuecomment-854739959 https://api.github.com/repos/pydata/xarray/issues/5436 MDEyOklzc3VlQ29tbWVudDg1NDczOTk1OQ== lanougue 32069530 2021-06-04T13:52:44Z 2021-06-04T13:52:44Z NONE

@keewis , do you think this behaviour to be the expected one ?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   bug or unclear definition of combine_attrs with xr.merge() 911513701

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);