issue_comments

Table actions

2 rows where issue = 905848466 and user = 37740986 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 1

  • thomashirtz · 2 ✖

issue 1

  • Add type checking when concat · 2 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
851618811 https://github.com/pydata/xarray/pull/5397#issuecomment-851618811 https://api.github.com/repos/pydata/xarray/issues/5397 MDEyOklzc3VlQ29tbWVudDg1MTYxODgxMQ== thomashirtz 37740986 2021-05-31T17:59:46Z 2021-05-31T17:59:46Z CONTRIBUTOR

Will it not cripple performance due to the non-lazy evaluation of the list ?

I also started the test for the concat function, I discovered that if the first element determine between _dataarray_concat and _dataset_concat. I am not sure if I need to do several commits (type checking dataset, type checking data array) and several test.

Here is the draft for the tests: ``` def test_concat_check_input_type(): ds = Dataset({"foo": 1}, {"bar": 2}) da = Dataset({"foo": 3}, {"bar": 4}).to_array(dim='foo')

# concatenate a list of non-homogeneous types must raise TypeError
with pytest.raises(TypeError, match="Some elements in the input list datasets are not 'DataSet'"):
    concat([ds, da], dim="foo")

# concatenate a list of non-homogeneous types must raise TypeError
with pytest.raises(TypeError, match="Some elements in the input list datasets are not 'DataArray'"):
    concat([da, ds], dim="foo")

```

Code I plan to add also for the typing check in _dataarray_concat: from .dataarray import DataArray arrays = list(arrays) if not all(isinstance(array, DataArray) for array in list(arrays)): raise TypeError("Some elements in the input list datasets are not 'DataArray'") (I need to add from .dataarray import DataArray to be able to use the type)

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add type checking when concat 905848466
850666780 https://github.com/pydata/xarray/pull/5397#issuecomment-850666780 https://api.github.com/repos/pydata/xarray/issues/5397 MDEyOklzc3VlQ29tbWVudDg1MDY2Njc4MA== thomashirtz 37740986 2021-05-28T20:58:53Z 2021-05-28T20:58:53Z CONTRIBUTOR

Ok! I'll do that in the next few days :) I'm trying to get more familiar with the whole procedure

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add type checking when concat 905848466

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);