issue_comments

Table actions

4 rows where issue = 902698424 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

author_association 2

issue 1

  • Type hints for xr.open_dataset · 4 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
862658124 https://github.com/pydata/xarray/issues/5382#issuecomment-862658124 https://api.github.com/repos/pydata/xarray/issues/5382 MDEyOklzc3VlQ29tbWVudDg2MjY1ODEyNA== max-sixty 5635139 2021-06-16T19:35:09Z 2021-06-16T19:35:09Z MEMBER

@krishnaap we'd welcome a Pull Request!

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Type hints for xr.open_dataset 902698424
862604807 https://github.com/pydata/xarray/issues/5382#issuecomment-862604807 https://api.github.com/repos/pydata/xarray/issues/5382 MDEyOklzc3VlQ29tbWVudDg2MjYwNDgwNw== krishnaap 10349239 2021-06-16T18:18:06Z 2021-06-16T18:18:06Z NONE

@shoyer how can I contribute to type hinting?

 
{
    "total_count": 1,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 1,
    "rocket": 0,
    "eyes": 0
}
   Type hints for xr.open_dataset 902698424
849150946 https://github.com/pydata/xarray/issues/5382#issuecomment-849150946 https://api.github.com/repos/pydata/xarray/issues/5382 MDEyOklzc3VlQ29tbWVudDg0OTE1MDk0Ng== adamjstewart 12021217 2021-05-26T22:04:15Z 2021-05-26T22:04:15Z NONE

Good to know, I'll try to add type hints and submit a PR if I get the chance.

 
{
    "total_count": 1,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 1,
    "rocket": 0,
    "eyes": 0
}
   Type hints for xr.open_dataset 902698424
848983657 https://github.com/pydata/xarray/issues/5382#issuecomment-848983657 https://api.github.com/repos/pydata/xarray/issues/5382 MDEyOklzc3VlQ29tbWVudDg0ODk4MzY1Nw== shoyer 1217238 2021-05-26T17:40:00Z 2021-05-26T17:40:00Z MEMBER

There's no timeline for complete type hinting -- or most other features in xarray, for that matter. Xarray is mostly a volunteer run project that depends on user contributions.

We would certainly welcome the addition of type hints for open_dataset(). At the very least, we could clarify that open_dataset() return an xarray.Dataset object.

 
{
    "total_count": 5,
    "+1": 5,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Type hints for xr.open_dataset 902698424

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);