issue_comments

Table actions

6 rows where issue = 895842334 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

author_association 2

issue 1

  • Fast-track unstack doesn't work with dask · 6 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
844495790 https://github.com/pydata/xarray/issues/5346#issuecomment-844495790 https://api.github.com/repos/pydata/xarray/issues/5346 MDEyOklzc3VlQ29tbWVudDg0NDQ5NTc5MA== max-sixty 5635139 2021-05-19T21:44:22Z 2021-05-19T21:44:22Z MEMBER

The new version is released and works with the original example. Thank a lot @aulemahal for the issue.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fast-track unstack doesn't work with dask 895842334
844484466 https://github.com/pydata/xarray/issues/5346#issuecomment-844484466 https://api.github.com/repos/pydata/xarray/issues/5346 MDEyOklzc3VlQ29tbWVudDg0NDQ4NDQ2Ng== max-sixty 5635139 2021-05-19T21:23:43Z 2021-05-19T21:23:43Z MEMBER

But I suppose I was a little too eager to get this working and it felt like I got caught in plenty of tests.

TBC, no great stress — both of us should have checked whether we had tests (and the project should have had them!).

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fast-track unstack doesn't work with dask 895842334
844483556 https://github.com/pydata/xarray/issues/5346#issuecomment-844483556 https://api.github.com/repos/pydata/xarray/issues/5346 MDEyOklzc3VlQ29tbWVudDg0NDQ4MzU1Ng== Illviljan 14371165 2021-05-19T21:22:12Z 2021-05-19T21:22:12Z MEMBER

Dask can do this nowadays:

python x = da.array([1, 2, 3, 5]) x[(Ellipsis, [1, 2])] = 6, 7 x[(Ellipsis, [0, 3])] = 9, 8 x.compute() Out[51]: array([9, 6, 7, 8])

But I suppose I was a little too eager to get this working and it felt like I got caught in plenty of tests.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fast-track unstack doesn't work with dask 895842334
844461920 https://github.com/pydata/xarray/issues/5346#issuecomment-844461920 https://api.github.com/repos/pydata/xarray/issues/5346 MDEyOklzc3VlQ29tbWVudDg0NDQ2MTkyMA== aulemahal 20629530 2021-05-19T20:49:28Z 2021-05-19T20:49:28Z CONTRIBUTOR

I'm not sure I understand the "dimensions" thing, isn't the MWE 1D? What is the case where it should work?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fast-track unstack doesn't work with dask 895842334
844460269 https://github.com/pydata/xarray/issues/5346#issuecomment-844460269 https://api.github.com/repos/pydata/xarray/issues/5346 MDEyOklzc3VlQ29tbWVudDg0NDQ2MDI2OQ== Illviljan 14371165 2021-05-19T20:46:56Z 2021-05-19T20:46:56Z MEMBER

Yeah, reverting it for now sounds good. Unless we can easily add a single dimension check?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fast-track unstack doesn't work with dask 895842334
844450703 https://github.com/pydata/xarray/issues/5346#issuecomment-844450703 https://api.github.com/repos/pydata/xarray/issues/5346 MDEyOklzc3VlQ29tbWVudDg0NDQ1MDcwMw== max-sixty 5635139 2021-05-19T20:32:40Z 2021-05-19T20:32:40Z MEMBER

That's not good.

Great spot @aulemahal . We may well not have tests for multiple dimensions.

We could revert this commit and release a patch release. Any thoughts @Illviljan ?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fast-track unstack doesn't work with dask 895842334

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);