home / github

Menu
  • Search all tables
  • GraphQL API

issue_comments

Table actions
  • GraphQL API for issue_comments

7 rows where issue = 893692903 sorted by updated_at descending

✖
✖

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

user 4

  • aulemahal 3
  • dcherian 2
  • max-sixty 1
  • andersy005 1

author_association 2

  • MEMBER 4
  • CONTRIBUTOR 3

issue 1

  • map_blocks doesn't handle tranposed arrays · 7 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
843208815 https://github.com/pydata/xarray/issues/5326#issuecomment-843208815 https://api.github.com/repos/pydata/xarray/issues/5326 MDEyOklzc3VlQ29tbWVudDg0MzIwODgxNQ== aulemahal 20629530 2021-05-18T14:14:37Z 2021-05-18T14:14:37Z CONTRIBUTOR

Thanks everyone. Just to be clear, I am using map_blocks in a rather complicated way (way more than this MWE) and at the moment of the map_blocks call, the code doesn't know the dimension order of the output, only the names. Moreover, in this code, the wrapped functions are too complex for map_blocks to infer the template. The idea is that all wrapped funcs reduce some dims or add some other (but with known sizes), thus I can construct a template, but the dim order is uncertain.

However, I understand that it is expected from map_blocks that the result fits the template, so my expectation was not correct. I'll leave the "workaround" in my code and close this issue. Thanks!

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  map_blocks doesn't handle tranposed arrays 893692903
842806452 https://github.com/pydata/xarray/issues/5326#issuecomment-842806452 https://api.github.com/repos/pydata/xarray/issues/5326 MDEyOklzc3VlQ29tbWVudDg0MjgwNjQ1Mg== dcherian 2448579 2021-05-18T03:58:50Z 2021-05-18T03:58:50Z MEMBER

I expected dimension order not to matter, as it is the case in most of xarray.

Yeah... the template is special, it must exactly match what the function returns. In your case, it seems like you know the dimension order. So you can transpose the template object to that dimension order

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  map_blocks doesn't handle tranposed arrays 893692903
842692873 https://github.com/pydata/xarray/issues/5326#issuecomment-842692873 https://api.github.com/repos/pydata/xarray/issues/5326 MDEyOklzc3VlQ29tbWVudDg0MjY5Mjg3Mw== andersy005 13301940 2021-05-17T22:51:54Z 2021-05-17T22:51:54Z MEMBER

I expected dimension order not to matter, as it is the case in most of xarray. Right now, my code wraps func in a another function that performs this transpose when needed.

Isn't it the case the order matters here because you are providing a template for map_blocks to follow? Would your code still work if you were to leave map_blocks to do the inference of the output dataset on its own as Deepak pointed out? From the code snippet you provided, it appears that map_blocks works without the template

python In [10]: dac.map_blocks(func).load() Out[10]: <xarray.DataArray <this-array> (y: 3, x: 2)> array([[0, 3], [1, 4], [2, 5]]) Dimensions without coordinates: y, x

{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  map_blocks doesn't handle tranposed arrays 893692903
842678176 https://github.com/pydata/xarray/issues/5326#issuecomment-842678176 https://api.github.com/repos/pydata/xarray/issues/5326 MDEyOklzc3VlQ29tbWVudDg0MjY3ODE3Ng== aulemahal 20629530 2021-05-17T22:17:23Z 2021-05-17T22:17:23Z CONTRIBUTOR

Haha, sorry, I didn't explain this properly.

This MWE is just MWE. The use case I have of map_blocks is in a decorator. At the moment I write the map_blocks call, I do not know if func will transpose the result or not. In my case, the template is generated from a list of dimensions to reduce and new dimensions.

I realize this might be an edge case that is too narrow to merit a fix. I expected dimension order not to matter, as it is the case in most of xarray. Right now, my code wraps func in a another function that performs this tranpose when needed.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  map_blocks doesn't handle tranposed arrays 893692903
842671637 https://github.com/pydata/xarray/issues/5326#issuecomment-842671637 https://api.github.com/repos/pydata/xarray/issues/5326 MDEyOklzc3VlQ29tbWVudDg0MjY3MTYzNw== dcherian 2448579 2021-05-17T22:02:31Z 2021-05-17T22:02:31Z MEMBER

You should be providing template = dac.transpose(). Does it work then? You can also not provide template in which case it will infer the right thing.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  map_blocks doesn't handle tranposed arrays 893692903
842668943 https://github.com/pydata/xarray/issues/5326#issuecomment-842668943 https://api.github.com/repos/pydata/xarray/issues/5326 MDEyOklzc3VlQ29tbWVudDg0MjY2ODk0Mw== aulemahal 20629530 2021-05-17T21:56:35Z 2021-05-17T21:56:35Z CONTRIBUTOR

Hi @max-sixty, just edited the top comment to include the traceback.

The MWE does work with return d.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  map_blocks doesn't handle tranposed arrays 893692903
842655926 https://github.com/pydata/xarray/issues/5326#issuecomment-842655926 https://api.github.com/repos/pydata/xarray/issues/5326 MDEyOklzc3VlQ29tbWVudDg0MjY1NTkyNg== max-sixty 5635139 2021-05-17T21:33:10Z 2021-05-17T21:33:10Z MEMBER

Hi @aulemahal !

Does this work with return d? Could you add the stack trace?

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  map_blocks doesn't handle tranposed arrays 893692903

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options:

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);
Powered by Datasette · Queries took 248.495ms · About: xarray-datasette
  • Sort ascending
  • Sort descending
  • Facet by this
  • Hide this column
  • Show all columns
  • Show not-blank rows