issue_comments

Table actions

9 rows where issue = 892421264 sorted by updated_at descending

✖
✖

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

author_association 2

issue 1

  • Use _unstack_once for valid dask and sparse versions · 9 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
842691922 https://github.com/pydata/xarray/pull/5315#issuecomment-842691922 https://api.github.com/repos/pydata/xarray/issues/5315 MDEyOklzc3VlQ29tbWVudDg0MjY5MTkyMg== max-sixty 5635139 2021-05-17T22:49:12Z 2021-05-17T22:49:12Z MEMBER

Great @Illviljan ! Feel free to add a whatsnew in a different PR — this is good news for lots of dask users

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Use _unstack_once for valid dask and sparse versions 892421264
841644944 https://github.com/pydata/xarray/pull/5315#issuecomment-841644944 https://api.github.com/repos/pydata/xarray/issues/5315 MDEyOklzc3VlQ29tbWVudDg0MTY0NDk0NA== pep8speaks 24736507 2021-05-15T11:43:03Z 2021-05-17T21:56:42Z NONE

Hello @Illviljan! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! :beers:

Comment last updated at 2021-05-17 21:56:42 UTC
 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Use _unstack_once for valid dask and sparse versions 892421264
842654462 https://github.com/pydata/xarray/pull/5315#issuecomment-842654462 https://api.github.com/repos/pydata/xarray/issues/5315 MDEyOklzc3VlQ29tbWVudDg0MjY1NDQ2Mg== max-sixty 5635139 2021-05-17T21:30:23Z 2021-05-17T21:30:23Z MEMBER

Looks great! Let's merge on green. Feel free to add a whatsnew @Illviljan !

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Use _unstack_once for valid dask and sparse versions 892421264
841843097 https://github.com/pydata/xarray/pull/5315#issuecomment-841843097 https://api.github.com/repos/pydata/xarray/issues/5315 MDEyOklzc3VlQ29tbWVudDg0MTg0MzA5Nw== keewis 14808389 2021-05-16T16:47:50Z 2021-05-16T16:47:50Z MEMBER

github actions currently has "degraded performance" (earlier today it was a "major outage")

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Use _unstack_once for valid dask and sparse versions 892421264
841838352 https://github.com/pydata/xarray/pull/5315#issuecomment-841838352 https://api.github.com/repos/pydata/xarray/issues/5315 MDEyOklzc3VlQ29tbWVudDg0MTgzODM1Mg== Illviljan 14371165 2021-05-16T16:10:45Z 2021-05-16T16:10:45Z MEMBER

@keewis any idea what it means when only 1 check has been run?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Use _unstack_once for valid dask and sparse versions 892421264
841759960 https://github.com/pydata/xarray/pull/5315#issuecomment-841759960 https://api.github.com/repos/pydata/xarray/issues/5315 MDEyOklzc3VlQ29tbWVudDg0MTc1OTk2MA== max-sixty 5635139 2021-05-16T03:25:34Z 2021-05-16T03:25:34Z MEMBER

yep, to really fix this we would have to change pint. I think it would be worth verifying whether we can check the interface (with hasattr) instead of type checking using isinstance, though.

Great, that could be a good workaround. What attr would we check for?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Use _unstack_once for valid dask and sparse versions 892421264
841745990 https://github.com/pydata/xarray/pull/5315#issuecomment-841745990 https://api.github.com/repos/pydata/xarray/issues/5315 MDEyOklzc3VlQ29tbWVudDg0MTc0NTk5MA== keewis 14808389 2021-05-16T00:43:49Z 2021-05-16T00:43:49Z MEMBER

yep, to really fix this we would have to change pint. I think it would be worth verifying whether we can check the interface (with hasattr) instead of type checking using isinstance, though.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Use _unstack_once for valid dask and sparse versions 892421264
841736265 https://github.com/pydata/xarray/pull/5315#issuecomment-841736265 https://api.github.com/repos/pydata/xarray/issues/5315 MDEyOklzc3VlQ29tbWVudDg0MTczNjI2NQ== max-sixty 5635139 2021-05-15T22:54:01Z 2021-05-15T22:54:01Z MEMBER

pint doesn't seem to be playing nice still @max-sixty. Seems some of your issues from #4746 are still there? Eventhough some of the issues in #4751 seems to have been solved.

@keewis any thoughts?

One (kinda bad) idea would be to branch on whether pint was installed — presumably if it's not installed then it can't cause the import issues. But changing dask performance based on whether pint is installed is not great!

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Use _unstack_once for valid dask and sparse versions 892421264
841723404 https://github.com/pydata/xarray/pull/5315#issuecomment-841723404 https://api.github.com/repos/pydata/xarray/issues/5315 MDEyOklzc3VlQ29tbWVudDg0MTcyMzQwNA== Illviljan 14371165 2021-05-15T20:50:19Z 2021-05-15T20:50:19Z MEMBER

pint doesn't seem to be playing nice still @max-sixty. Seems some of your issues from #4746 are still there? Eventhough some of the issues in #4751 seems to have been solved.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Use _unstack_once for valid dask and sparse versions 892421264

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);