issue_comments

Table actions

12 rows where issue = 891200849 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

issue 1

  • 0.18.1 patch release? · 12 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
844460467 https://github.com/pydata/xarray/issues/5298#issuecomment-844460467 https://api.github.com/repos/pydata/xarray/issues/5298 MDEyOklzc3VlQ29tbWVudDg0NDQ2MDQ2Nw== max-sixty 5635139 2021-05-19T20:47:13Z 2021-05-19T20:47:13Z MEMBER

I'm curious.. How are these "new main branches" different from git tags from releases?

I had meant commit rather than branch — i.e. "on every commit to master". But as a thought experiment rather than a proposal

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   0.18.1 patch release? 891200849
844457262 https://github.com/pydata/xarray/issues/5298#issuecomment-844457262 https://api.github.com/repos/pydata/xarray/issues/5298 MDEyOklzc3VlQ29tbWVudDg0NDQ1NzI2Mg== andersy005 13301940 2021-05-19T20:42:25Z 2021-05-19T20:42:25Z MEMBER

Here's one example that shows github-activity in action: https://jupyterbook.org/reference/_changelog.html

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   0.18.1 patch release? 891200849
844455537 https://github.com/pydata/xarray/issues/5298#issuecomment-844455537 https://api.github.com/repos/pydata/xarray/issues/5298 MDEyOklzc3VlQ29tbWVudDg0NDQ1NTUzNw== andersy005 13301940 2021-05-19T20:39:43Z 2021-05-19T20:39:43Z MEMBER

Glad to hear that releasing is getting easier/simpler :)

There are some smaller tasks we can put into pipelines if we want to squeeze more out there (e.g. updating stable branch, adding contributor lists). The only really necessary tasks are writing the summary, organizing the whatsnew, sending out communications.

I've been thinking about this, and I'm wondering if something like this great tool: github-activity could help us (at least with updating whatsnew.rst). github-activity is able to generate the changelog from the GitHub API. This would eliminate the need for updating whatsnew.rst multiple times (once for each PR). With proper labels, github-activity is able to categorize PRs and Issues during the changelog generation. Another cool feature of github-activity is that it includes other contributions in addition to the default PR submissions: https://github-activity.readthedocs.io/en/latest/#how-does-this-tool-define-contributions-in-the-reports

There's an extreme end of "constantly release new main branches". I don't see anything functionally wrong with that, but I'm sure there are unexplored consequences, and I'm not sure our role is to forge a new path in OSS release cycles.

I'm curious.. How are these "new main branches" different from git tags from releases?

So maybe monthly is a reasonable balance?

👍🏽 for frequent/monthly release cadence 

{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   0.18.1 patch release? 891200849
844423790 https://github.com/pydata/xarray/issues/5298#issuecomment-844423790 https://api.github.com/repos/pydata/xarray/issues/5298 MDEyOklzc3VlQ29tbWVudDg0NDQyMzc5MA== max-sixty 5635139 2021-05-19T19:56:08Z 2021-05-19T19:56:54Z MEMBER

From https://github.com/pydata/xarray/pull/4753#issuecomment-841894087

I wonder if we should hold off on merging until after the 0.18.1 release -- or maybe just move to a date based versioning system / release cycle like dask.

I am keen on whatever lets us release faster and easier — very open to a set schedule.

Releasing has got to a place such that increasing the frequency isn't costly. The recent work by @andersy005 and others to automate PyPI has made that even more so. There are some smaller tasks we can put into pipelines if we want to squeeze more out there (e.g. updating stable branch, adding contributor lists). The only really necessary tasks are writing the summary, organizing the whatsnew, sending out communications.

There's an extreme end of "constantly release new main branches". I don't see anything functionally wrong with that, but I'm sure there are unexplored consequences, and I'm not sure our role is to forge a new path in OSS release cycles.

So maybe monthly is a reasonable balance?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   0.18.1 patch release? 891200849
844096658 https://github.com/pydata/xarray/issues/5298#issuecomment-844096658 https://api.github.com/repos/pydata/xarray/issues/5298 MDEyOklzc3VlQ29tbWVudDg0NDA5NjY1OA== dcherian 2448579 2021-05-19T13:16:11Z 2021-05-19T13:16:11Z MEMBER

Thanks Max! Looks like that went pretty smoothly!

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   0.18.1 patch release? 891200849
843819279 https://github.com/pydata/xarray/issues/5298#issuecomment-843819279 https://api.github.com/repos/pydata/xarray/issues/5298 MDEyOklzc3VlQ29tbWVudDg0MzgxOTI3OQ== shoyer 1217238 2021-05-19T07:21:35Z 2021-05-19T07:21:35Z MEMBER

thanks Max!

We can always do a 0.18.2 for https://github.com/pydata/xarray/issues/5329 if need be :)

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   0.18.1 patch release? 891200849
843799396 https://github.com/pydata/xarray/issues/5298#issuecomment-843799396 https://api.github.com/repos/pydata/xarray/issues/5298 MDEyOklzc3VlQ29tbWVudDg0Mzc5OTM5Ng== max-sixty 5635139 2021-05-19T06:53:12Z 2021-05-19T06:53:12Z MEMBER

This is done. I'll send an email & check the docs are working tomorrow. Let me know anything I missed!

 
{
    "total_count": 1,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 1,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   0.18.1 patch release? 891200849
843268310 https://github.com/pydata/xarray/issues/5298#issuecomment-843268310 https://api.github.com/repos/pydata/xarray/issues/5298 MDEyOklzc3VlQ29tbWVudDg0MzI2ODMxMA== dcherian 2448579 2021-05-18T15:25:06Z 2021-05-18T15:25:06Z MEMBER

shall we merge #5300 and release? Users are running in to the map_blocks issue, see #5331

 
{
    "total_count": 3,
    "+1": 3,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   0.18.1 patch release? 891200849
840849956 https://github.com/pydata/xarray/issues/5298#issuecomment-840849956 https://api.github.com/repos/pydata/xarray/issues/5298 MDEyOklzc3VlQ29tbWVudDg0MDg0OTk1Ng== keewis 14808389 2021-05-13T21:37:38Z 2021-05-13T21:37:38Z MEMBER

I can also help with the release.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   0.18.1 patch release? 891200849
840733277 https://github.com/pydata/xarray/issues/5298#issuecomment-840733277 https://api.github.com/repos/pydata/xarray/issues/5298 MDEyOklzc3VlQ29tbWVudDg0MDczMzI3Nw== max-sixty 5635139 2021-05-13T18:04:52Z 2021-05-13T18:04:52Z MEMBER

I can "do the release" if that's helpful

 
{
    "total_count": 1,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 1,
    "eyes": 0
}
   0.18.1 patch release? 891200849
840700991 https://github.com/pydata/xarray/issues/5298#issuecomment-840700991 https://api.github.com/repos/pydata/xarray/issues/5298 MDEyOklzc3VlQ29tbWVudDg0MDcwMDk5MQ== shoyer 1217238 2021-05-13T17:09:54Z 2021-05-13T17:09:54Z MEMBER

I'd also love to get https://github.com/pydata/xarray/pull/5252 in (it makes to_zarr() with region much faster / more efficient), but it's not really urgent.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   0.18.1 patch release? 891200849
840700320 https://github.com/pydata/xarray/issues/5298#issuecomment-840700320 https://api.github.com/repos/pydata/xarray/issues/5298 MDEyOklzc3VlQ29tbWVudDg0MDcwMDMyMA== shoyer 1217238 2021-05-13T17:08:49Z 2021-05-13T17:08:49Z MEMBER

I'm going to take a look into fixing #5291 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   0.18.1 patch release? 891200849

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);