issue_comments

Table actions

5 rows where issue = 884649380 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

author_association 2

issue 1

  • Support for pandas Extension Arrays · 5 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
847418464 https://github.com/pydata/xarray/issues/5287#issuecomment-847418464 https://api.github.com/repos/pydata/xarray/issues/5287 MDEyOklzc3VlQ29tbWVudDg0NzQxODQ2NA== jbrockmendel 8078968 2021-05-24T23:25:56Z 2021-05-24T23:25:56Z NONE

Unfortunately, pandas-dev/pandas#35032 was closed

I'm hoping to re-open at some point. The trouble I ran into is that a) there isn't any way to implement __array_function__ incrementally and b) there aren't any assurances on where self is among the args and kwargs passed to __array_function__. The workarounds I came up with for the latter were pretty ugly. Input would be welcome.

Keep in mind that PR implemented __array_function__ for NDArrayBackedExtensionArray (includes DatetimeArray, TimedeltaArray, PeriodArray, Categorical (and i expect most 3rd party EAs will be natural candidates)). Implementing it on the base ExtensionArray class would be a different animal.

Support N-D data, on top of pandas' 1D API. This would make extension arrays more generally useful in Xarray, but some operations might be hard to do efficiently

ATM NDArrayBackedExtensionArray explicitly supports 2D, and because it is a thin wrapper around np.ndarray higher-dimensions should either work or be within spitting distance of working.

I'm trying to get support for 2D more generally (xref https://github.com/pandas-dev/pandas/pull/38992), but at best it will be a while before that becomes a reality.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Support for pandas Extension Arrays 884649380
839079791 https://github.com/pydata/xarray/issues/5287#issuecomment-839079791 https://api.github.com/repos/pydata/xarray/issues/5287 MDEyOklzc3VlQ29tbWVudDgzOTA3OTc5MQ== shoyer 1217238 2021-05-11T19:55:37Z 2021-05-11T19:55:37Z MEMBER

If they added NEP-18 support, many things would work automatically, wouldn't it?

In my opinion, NEP-18 support is probably out of scope for pandas.

But this would totally make sense for a separate mini-project, to make a NumPy compatible wrapper of pandas extension arrays.

I see two possible levels of support here: 1. Only 1D data, with NumPy's API. Operations that would produce multi-dimensional data raise an error. 2. Support N-D data, on top of pandas' 1D API. This would make extension arrays more generally useful in Xarray, but some operations might be hard to do efficiently.

 
{
    "total_count": 2,
    "+1": 2,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Support for pandas Extension Arrays 884649380
837516418 https://github.com/pydata/xarray/issues/5287#issuecomment-837516418 https://api.github.com/repos/pydata/xarray/issues/5287 MDEyOklzc3VlQ29tbWVudDgzNzUxNjQxOA== dcherian 2448579 2021-05-10T23:54:29Z 2021-05-10T23:54:29Z MEMBER

If they added NEP-18 support, many things would work automatically, wouldn't it?

xref https://github.com/pandas-dev/pandas/issues/26380

Unfortunately, https://github.com/pandas-dev/pandas/pull/35032 was closed.

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Support for pandas Extension Arrays 884649380
837454168 https://github.com/pydata/xarray/issues/5287#issuecomment-837454168 https://api.github.com/repos/pydata/xarray/issues/5287 MDEyOklzc3VlQ29tbWVudDgzNzQ1NDE2OA== max-sixty 5635139 2021-05-10T22:49:43Z 2021-05-10T22:49:43Z MEMBER

If there were sufficient demand and development effort for pandas extension arrays, I think there's be interest in adding it without waiting for numpy, similar to how we handle dask / sparse arrays.

But I imagine it would be a decently sized project, and AFAIK no one from the existing core dev team has expressed interest in taking it on, so it would have to come from others. And it's probably a convex project that's only useful once it's completed — rather than marginally helpful with marginal improvements.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Support for pandas Extension Arrays 884649380
837039218 https://github.com/pydata/xarray/issues/5287#issuecomment-837039218 https://api.github.com/repos/pydata/xarray/issues/5287 MDEyOklzc3VlQ29tbWVudDgzNzAzOTIxOA== keewis 14808389 2021-05-10T17:48:51Z 2021-05-10T17:49:11Z MEMBER

I think I remember reading somewhere that we want to keep being compatible with numpy, which means that we're waiting for NEP40-43 to be included in a release. As far as I can tell that might still take a while, though, the implementation is not quite there yet.

Edit: in any case, I think something like that would be really useful

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Support for pandas Extension Arrays 884649380

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);