issue_comments

Table actions

14 rows where issue = 874331538 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

author_association 3

issue 1

  • Add mode="r+" for to_zarr and use consolidated writes/reads by default · 14 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
865602081 https://github.com/pydata/xarray/pull/5252#issuecomment-865602081 https://api.github.com/repos/pydata/xarray/issues/5252 MDEyOklzc3VlQ29tbWVudDg2NTYwMjA4MQ== shoyer 1217238 2021-06-22T05:26:21Z 2021-06-22T05:26:21Z MEMBER

Well hey, it's still not too late to catch any issues before they turn up in a released version of Xarray :)

On Mon, Jun 21, 2021 at 11:56 PM Noah D. Brenowitz @.***> wrote:

I'm sorry too! I don't have any good excuse though...

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/pydata/xarray/pull/5252#issuecomment-865554874, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAJJFVXBEQCIEIUDKLD6NBLTUAJXLANCNFSM44ALL2AQ . 

{
    "total_count": 1,
    "+1": 0,
    "-1": 0,
    "laugh": 1,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add mode="r+" for to_zarr and use consolidated writes/reads by default 874331538
865554874 https://github.com/pydata/xarray/pull/5252#issuecomment-865554874 https://api.github.com/repos/pydata/xarray/issues/5252 MDEyOklzc3VlQ29tbWVudDg2NTU1NDg3NA== nbren12 1386642 2021-06-22T04:56:09Z 2021-06-22T04:56:09Z CONTRIBUTOR

I'm sorry too! I don't have any good excuse though...

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add mode="r+" for to_zarr and use consolidated writes/reads by default 874331538
863452266 https://github.com/pydata/xarray/pull/5252#issuecomment-863452266 https://api.github.com/repos/pydata/xarray/issues/5252 MDEyOklzc3VlQ29tbWVudDg2MzQ1MjI2Ng== rabernat 1197350 2021-06-17T18:07:28Z 2021-06-17T18:07:28Z MEMBER

Really sorry I didn't get around to review. My excuse is that I moved back to NYC last week and fell behind on everything. Thanks for moving it forward. 💪 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add mode="r+" for to_zarr and use consolidated writes/reads by default 874331538
863438051 https://github.com/pydata/xarray/pull/5252#issuecomment-863438051 https://api.github.com/repos/pydata/xarray/issues/5252 MDEyOklzc3VlQ29tbWVudDg2MzQzODA1MQ== github-actions[bot] 41898282 2021-06-17T17:47:18Z 2021-06-17T17:47:18Z CONTRIBUTOR

Unit Test Results

0 files  ±0  0 suites  ±0   0s :stopwatch: ±0s 0 tests ±0  0 :heavy_check_mark: ±0  0 :zzz: ±0  0 :x: ±0 

Results for commit 158bc525. ± Comparison against base commit 158bc525.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add mode="r+" for to_zarr and use consolidated writes/reads by default 874331538
863420393 https://github.com/pydata/xarray/pull/5252#issuecomment-863420393 https://api.github.com/repos/pydata/xarray/issues/5252 MDEyOklzc3VlQ29tbWVudDg2MzQyMDM5Mw== dcherian 2448579 2021-06-17T17:19:20Z 2021-06-17T17:19:20Z MEMBER

it seems to be working pretty well.

best kind of code review!

Thanks @shoyer 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add mode="r+" for to_zarr and use consolidated writes/reads by default 874331538
863412302 https://github.com/pydata/xarray/pull/5252#issuecomment-863412302 https://api.github.com/repos/pydata/xarray/issues/5252 MDEyOklzc3VlQ29tbWVudDg2MzQxMjMwMg== shoyer 1217238 2021-06-17T17:07:26Z 2021-06-17T17:07:26Z MEMBER

I vote to merge since it's so useful and @shoyer has probably found all the bugs already :)

Hah :). We've been using this branch at Google for a while now and it seems to be working pretty well.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add mode="r+" for to_zarr and use consolidated writes/reads by default 874331538
863369218 https://github.com/pydata/xarray/pull/5252#issuecomment-863369218 https://api.github.com/repos/pydata/xarray/issues/5252 MDEyOklzc3VlQ29tbWVudDg2MzM2OTIxOA== dcherian 2448579 2021-06-17T16:07:15Z 2021-06-17T16:07:15Z MEMBER

I vote to merge since it's so useful and @shoyer has probably found all the bugs already :)

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add mode="r+" for to_zarr and use consolidated writes/reads by default 874331538
833772022 https://github.com/pydata/xarray/pull/5252#issuecomment-833772022 https://api.github.com/repos/pydata/xarray/issues/5252 MDEyOklzc3VlQ29tbWVudDgzMzc3MjAyMg== pep8speaks 24736507 2021-05-06T18:47:31Z 2021-06-17T16:06:29Z NONE

Hello @shoyer! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! :beers:

Comment last updated at 2021-06-17 16:06:29 UTC
 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add mode="r+" for to_zarr and use consolidated writes/reads by default 874331538
858863681 https://github.com/pydata/xarray/pull/5252#issuecomment-858863681 https://api.github.com/repos/pydata/xarray/issues/5252 MDEyOklzc3VlQ29tbWVudDg1ODg2MzY4MQ== shoyer 1217238 2021-06-10T18:16:55Z 2021-06-10T18:16:55Z MEMBER

@nbren12 @spencerkclark are either of you up for a review here?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add mode="r+" for to_zarr and use consolidated writes/reads by default 874331538
858862846 https://github.com/pydata/xarray/pull/5252#issuecomment-858862846 https://api.github.com/repos/pydata/xarray/issues/5252 MDEyOklzc3VlQ29tbWVudDg1ODg2Mjg0Ng== shoyer 1217238 2021-06-10T18:16:05Z 2021-06-10T18:16:05Z MEMBER

@rabernat gentle ping for review here :)

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add mode="r+" for to_zarr and use consolidated writes/reads by default 874331538
833648389 https://github.com/pydata/xarray/pull/5252#issuecomment-833648389 https://api.github.com/repos/pydata/xarray/issues/5252 MDEyOklzc3VlQ29tbWVudDgzMzY0ODM4OQ== shoyer 1217238 2021-05-06T16:11:00Z 2021-05-06T16:11:00Z MEMBER

Thanks @joshmoore for the copy-editing!

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add mode="r+" for to_zarr and use consolidated writes/reads by default 874331538
832256725 https://github.com/pydata/xarray/pull/5252#issuecomment-832256725 https://api.github.com/repos/pydata/xarray/issues/5252 MDEyOklzc3VlQ29tbWVudDgzMjI1NjcyNQ== shoyer 1217238 2021-05-04T21:20:48Z 2021-05-04T21:20:48Z MEMBER

I pushed a commit making consolidated metadata the default (see https://github.com/pydata/xarray/issues/5251). This was easier to do building on top of my existing refactor here (but conceivably could be separated).

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add mode="r+" for to_zarr and use consolidated writes/reads by default 874331538
832075854 https://github.com/pydata/xarray/pull/5252#issuecomment-832075854 https://api.github.com/repos/pydata/xarray/issues/5252 MDEyOklzc3VlQ29tbWVudDgzMjA3NTg1NA== shoyer 1217238 2021-05-04T16:28:43Z 2021-05-04T16:28:43Z MEMBER

Nope, not anymore! We decide the existing variables (to figure out/match their encoding) but that's done in a lazy way. We never put them in an xarray.Dataset so there is no eager loading of dimension coordinates.

On Tue, May 4, 2021 at 7:07 AM Ryan Abernathey @.***> wrote:

Question: does this mode still require eager loading of dimension coordinates?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/pydata/xarray/pull/5252#issuecomment-831970193, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAJJFVVIPHXHCNFR2GJXJKDTL75R5ANCNFSM44ALL2AQ . 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add mode="r+" for to_zarr and use consolidated writes/reads by default 874331538
831970193 https://github.com/pydata/xarray/pull/5252#issuecomment-831970193 https://api.github.com/repos/pydata/xarray/issues/5252 MDEyOklzc3VlQ29tbWVudDgzMTk3MDE5Mw== rabernat 1197350 2021-05-04T14:07:03Z 2021-05-04T14:07:03Z MEMBER

Question: does this mode still require eager loading of dimension coordinates?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add mode="r+" for to_zarr and use consolidated writes/reads by default 874331538

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);