issue_comments

Table actions

10 rows where issue = 874231291 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

user 3

issue 1

  • Fix bulleted list indentation in docstrings · 10 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
832139447 https://github.com/pydata/xarray/pull/5250#issuecomment-832139447 https://api.github.com/repos/pydata/xarray/issues/5250 MDEyOklzc3VlQ29tbWVudDgzMjEzOTQ0Nw== keewis 14808389 2021-05-04T18:08:22Z 2021-05-04T18:09:00Z MEMBER

Have you had a chance to test drive it lately?

no, I didn't.

Maybe it's time to let Velin spring free!

I'll need to investigate more, but I think we should probably do that soon. There should be standard rst linters, too, but those might need more configuration: sphinx adds a lot of new directives.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix bulleted list indentation in docstrings 874231291
831631827 https://github.com/pydata/xarray/pull/5250#issuecomment-831631827 https://api.github.com/repos/pydata/xarray/issues/5250 MDEyOklzc3VlQ29tbWVudDgzMTYzMTgyNw== max-sixty 5635139 2021-05-04T01:18:10Z 2021-05-04T01:18:10Z MEMBER

Thank you @andersy005 !

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix bulleted list indentation in docstrings 874231291
831599258 https://github.com/pydata/xarray/pull/5250#issuecomment-831599258 https://api.github.com/repos/pydata/xarray/issues/5250 MDEyOklzc3VlQ29tbWVudDgzMTU5OTI1OA== andersy005 13301940 2021-05-03T23:33:27Z 2021-05-03T23:33:27Z MEMBER

Thanks, @max-sixty 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix bulleted list indentation in docstrings 874231291
831596203 https://github.com/pydata/xarray/pull/5250#issuecomment-831596203 https://api.github.com/repos/pydata/xarray/issues/5250 MDEyOklzc3VlQ29tbWVudDgzMTU5NjIwMw== max-sixty 5635139 2021-05-03T23:23:45Z 2021-05-03T23:23:45Z MEMBER

@andersy005 I'll hit the button here, if that's OK with you?

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix bulleted list indentation in docstrings 874231291
831596107 https://github.com/pydata/xarray/pull/5250#issuecomment-831596107 https://api.github.com/repos/pydata/xarray/issues/5250 MDEyOklzc3VlQ29tbWVudDgzMTU5NjEwNw== max-sixty 5635139 2021-05-03T23:23:26Z 2021-05-03T23:23:26Z MEMBER

Maybe it's time to let Velin spring free! @keewis up to you, as ever

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix bulleted list indentation in docstrings 874231291
831455032 https://github.com/pydata/xarray/pull/5250#issuecomment-831455032 https://api.github.com/repos/pydata/xarray/issues/5250 MDEyOklzc3VlQ29tbWVudDgzMTQ1NTAzMg== andersy005 13301940 2021-05-03T18:43:11Z 2021-05-03T18:43:11Z MEMBER

the initial issue, at least, would have been caught by velin

Right... In a previous comment https://github.com/pydata/xarray/pull/4872#issue-568848688 you mentioned that the primary reason the velin hook was deactivated is because of the package maturity. Have you had a chance to test drive it lately? Is there a timeline on when we should activate it?

https://github.com/pydata/xarray/blob/9f118624e7924c80fc305f351fa9621d2b58514c/.pre-commit-config.yaml#L27-L30 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix bulleted list indentation in docstrings 874231291
831447687 https://github.com/pydata/xarray/pull/5250#issuecomment-831447687 https://api.github.com/repos/pydata/xarray/issues/5250 MDEyOklzc3VlQ29tbWVudDgzMTQ0NzY4Nw== keewis 14808389 2021-05-03T18:31:14Z 2021-05-03T18:31:14Z MEMBER

the initial issue, at least, would have been caught by velin

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix bulleted list indentation in docstrings 874231291
831406853 https://github.com/pydata/xarray/pull/5250#issuecomment-831406853 https://api.github.com/repos/pydata/xarray/issues/5250 MDEyOklzc3VlQ29tbWVudDgzMTQwNjg1Mw== andersy005 13301940 2021-05-03T17:20:50Z 2021-05-03T17:21:02Z MEMBER

If there's a way of auto-failing anything that violates this, that would keep it good. But maybe the previous text is indistinguishable from normal prose...

Not sure there's a way to automatically detect these issues :( 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix bulleted list indentation in docstrings 874231291
831405990 https://github.com/pydata/xarray/pull/5250#issuecomment-831405990 https://api.github.com/repos/pydata/xarray/issues/5250 MDEyOklzc3VlQ29tbWVudDgzMTQwNTk5MA== andersy005 13301940 2021-05-03T17:19:23Z 2021-05-03T17:19:23Z MEMBER

@max-sixty, the inconsistencies are now fixed... 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix bulleted list indentation in docstrings 874231291
831053909 https://github.com/pydata/xarray/pull/5250#issuecomment-831053909 https://api.github.com/repos/pydata/xarray/issues/5250 MDEyOklzc3VlQ29tbWVudDgzMTA1MzkwOQ== max-sixty 5635139 2021-05-03T06:36:32Z 2021-05-03T06:36:41Z MEMBER

That looks great! Thanks!

If there's a way of auto-failing anything that violates this, that would keep it good. But maybe the previous text is indistinguishable from normal prose...

Not worth worrying about at all — really — FYI this looks a tiny bit inconsistent: 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix bulleted list indentation in docstrings 874231291

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);