issue_comments

Table actions

4 rows where issue = 870782371 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

user 3

author_association 3

issue 1

  • Fix exception when display_expand_data=False for file-backed array. · 4 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
832598978 https://github.com/pydata/xarray/pull/5235#issuecomment-832598978 https://api.github.com/repos/pydata/xarray/issues/5235 MDEyOklzc3VlQ29tbWVudDgzMjU5ODk3OA== keewis 14808389 2021-05-05T10:59:54Z 2021-05-05T17:01:13Z MEMBER

I agree, this looks ready. We classified this as a release blocker so it will definitely be part of the release. Before merging I'd like to have another maintainer look over this, though, to check my decisions.

 
{
    "total_count": 2,
    "+1": 2,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix exception when display_expand_data=False for file-backed array. 870782371
832596127 https://github.com/pydata/xarray/pull/5235#issuecomment-832596127 https://api.github.com/repos/pydata/xarray/issues/5235 MDEyOklzc3VlQ29tbWVudDgzMjU5NjEyNw== tomwhite 85085 2021-05-05T10:54:17Z 2021-05-05T10:54:17Z CONTRIBUTOR

This is now passing. We could add more tests or even change the representation a little in some cases, but it would be good to merge for the release (since it fixes a bug) if it looks OK to you @keewis.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix exception when display_expand_data=False for file-backed array. 870782371
831763281 https://github.com/pydata/xarray/pull/5235#issuecomment-831763281 https://api.github.com/repos/pydata/xarray/issues/5235 MDEyOklzc3VlQ29tbWVudDgzMTc2MzI4MQ== pep8speaks 24736507 2021-05-04T08:15:54Z 2021-05-05T10:10:40Z NONE

Hello @tomwhite! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! :beers:

Comment last updated at 2021-05-05 10:10:40 UTC
 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix exception when display_expand_data=False for file-backed array. 870782371
832567341 https://github.com/pydata/xarray/pull/5235#issuecomment-832567341 https://api.github.com/repos/pydata/xarray/issues/5235 MDEyOklzc3VlQ29tbWVudDgzMjU2NzM0MQ== keewis 14808389 2021-05-05T10:02:26Z 2021-05-05T10:02:26Z MEMBER

once we get the CI to pass, this should be ready for merging. Just note that I'm not entirely sure about the size of the test array.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix exception when display_expand_data=False for file-backed array. 870782371

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);