issue_comments

Table actions

10 rows where issue = 870292042 and user = 14808389 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

user 1

  • keewis · 10 ✖

issue 1

  • release v0.18.0 · 10 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
833779348 https://github.com/pydata/xarray/issues/5232#issuecomment-833779348 https://api.github.com/repos/pydata/xarray/issues/5232 MDEyOklzc3VlQ29tbWVudDgzMzc3OTM0OA== keewis 14808389 2021-05-06T18:54:39Z 2021-05-06T18:56:22Z MEMBER

ah, right, only the "push tag" workflow run failed

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   release v0.18.0 870292042
833777039 https://github.com/pydata/xarray/issues/5232#issuecomment-833777039 https://api.github.com/repos/pydata/xarray/issues/5232 MDEyOklzc3VlQ29tbWVudDgzMzc3NzAzOQ== keewis 14808389 2021-05-06T18:51:30Z 2021-05-06T18:51:30Z MEMBER

maybe we should make the "upload to TestPyPI" a separate step?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   release v0.18.0 870292042
833776140 https://github.com/pydata/xarray/issues/5232#issuecomment-833776140 https://api.github.com/repos/pydata/xarray/issues/5232 MDEyOklzc3VlQ29tbWVudDgzMzc3NjE0MA== keewis 14808389 2021-05-06T18:51:04Z 2021-05-06T18:51:04Z MEMBER

errr... we can't do anything about that, PyPI and TestPyPI don't allow republishing the same version

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   release v0.18.0 870292042
833773673 https://github.com/pydata/xarray/issues/5232#issuecomment-833773673 https://api.github.com/repos/pydata/xarray/issues/5232 MDEyOklzc3VlQ29tbWVudDgzMzc3MzY3Mw== keewis 14808389 2021-05-06T18:49:44Z 2021-05-06T18:50:22Z MEMBER

yes, please. The command to create the tag should be ```

empty commit unless you update the release date there

git commit --empty -am 'Release v0.18.0' git tag -a v0.18.0 -m 'v0.18.0' ```

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   release v0.18.0 870292042
833682044 https://github.com/pydata/xarray/issues/5232#issuecomment-833682044 https://api.github.com/repos/pydata/xarray/issues/5232 MDEyOklzc3VlQ29tbWVudDgzMzY4MjA0NA== keewis 14808389 2021-05-06T16:51:28Z 2021-05-06T16:51:28Z MEMBER

not sure how far you got with the release, but it would be good to get #5272 in before that.

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   release v0.18.0 870292042
833651866 https://github.com/pydata/xarray/issues/5232#issuecomment-833651866 https://api.github.com/repos/pydata/xarray/issues/5232 MDEyOklzc3VlQ29tbWVudDgzMzY1MTg2Ng== keewis 14808389 2021-05-06T16:14:44Z 2021-05-06T16:14:44Z MEMBER

uploading to TestPyPI works so uploading to PyPI should work, too, once we have the token

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   release v0.18.0 870292042
833610586 https://github.com/pydata/xarray/issues/5232#issuecomment-833610586 https://api.github.com/repos/pydata/xarray/issues/5232 MDEyOklzc3VlQ29tbWVudDgzMzYxMDU4Ng== keewis 14808389 2021-05-06T15:22:57Z 2021-05-06T15:23:29Z MEMBER

5235 shouldn't be that much of an issue. There are two decisions to check: never collapse the repr of MemoryCachedArray and keep the array used to check that small (we have a limit of 1e5, after which the repr changes from array([...]) to [xyz values with dtype=...])

Edit: essentially: I don't want to merge it myself

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   release v0.18.0 870292042
832588071 https://github.com/pydata/xarray/issues/5232#issuecomment-832588071 https://api.github.com/repos/pydata/xarray/issues/5232 MDEyOklzc3VlQ29tbWVudDgzMjU4ODA3MQ== keewis 14808389 2021-05-05T10:37:49Z 2021-05-05T10:40:47Z MEMBER

I think that's because nobody had that idea, yet.

Edit: that would also help with the idea in https://github.com/pydata/xarray/pull/5244#issuecomment-831511929. Let's continue that discussion in #5244

 
{
    "total_count": 1,
    "+1": 0,
    "-1": 0,
    "laugh": 1,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   release v0.18.0 870292042
832563855 https://github.com/pydata/xarray/issues/5232#issuecomment-832563855 https://api.github.com/repos/pydata/xarray/issues/5232 MDEyOklzc3VlQ29tbWVudDgzMjU2Mzg1NQ== keewis 14808389 2021-05-05T09:56:42Z 2021-05-05T09:56:42Z MEMBER

we could also temporarily switch the uploads to test.pypi.org to verify, create debug versions (rc candidates?) and switch back to pypi.org once we're confident

 
{
    "total_count": 2,
    "+1": 2,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   release v0.18.0 870292042
831362303 https://github.com/pydata/xarray/issues/5232#issuecomment-831362303 https://api.github.com/repos/pydata/xarray/issues/5232 MDEyOklzc3VlQ29tbWVudDgzMTM2MjMwMw== keewis 14808389 2021-05-03T16:03:33Z 2021-05-03T16:03:33Z MEMBER

great, you're a maintainer now (for pint-xarray, too, btw)

 
{
    "total_count": 2,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 2,
    "rocket": 0,
    "eyes": 0
}
   release v0.18.0 870292042

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);