issue_comments

Table actions

6 rows where issue = 870292042 and user = 13301940 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

user 1

  • andersy005 · 6 ✖

issue 1

  • release v0.18.0 · 6 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
833782283 https://github.com/pydata/xarray/issues/5232#issuecomment-833782283 https://api.github.com/repos/pydata/xarray/issues/5232 MDEyOklzc3VlQ29tbWVudDgzMzc4MjI4Mw== andersy005 13301940 2021-05-06T18:59:01Z 2021-05-06T18:59:01Z MEMBER

maybe we should make the "upload to TestPyPI" a separate step?

Or we could just set

yaml skip_existing: true

on the upload to TestPyPI step. 

{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   release v0.18.0 870292042
833774532 https://github.com/pydata/xarray/issues/5232#issuecomment-833774532 https://api.github.com/repos/pydata/xarray/issues/5232 MDEyOklzc3VlQ29tbWVudDgzMzc3NDUzMg== andersy005 13301940 2021-05-06T18:50:11Z 2021-05-06T18:50:46Z MEMBER

@keewis, do we need to do anything with the release on test.pypi.org? (since the v0.18 is already published there)

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   release v0.18.0 870292042
833772828 https://github.com/pydata/xarray/issues/5232#issuecomment-833772828 https://api.github.com/repos/pydata/xarray/issues/5232 MDEyOklzc3VlQ29tbWVudDgzMzc3MjgyOA== andersy005 13301940 2021-05-06T18:48:41Z 2021-05-06T18:48:41Z MEMBER

hmm should I also delete the tag?

Yes...

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   release v0.18.0 870292042
833768930 https://github.com/pydata/xarray/issues/5232#issuecomment-833768930 https://api.github.com/repos/pydata/xarray/issues/5232 MDEyOklzc3VlQ29tbWVudDgzMzc2ODkzMA== andersy005 13301940 2021-05-06T18:43:04Z 2021-05-06T18:43:04Z MEMBER

I accidentally closed this via Github's keywords... The bug in the CI workflow should be fixed. 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   release v0.18.0 870292042
833753256 https://github.com/pydata/xarray/issues/5232#issuecomment-833753256 https://api.github.com/repos/pydata/xarray/issues/5232 MDEyOklzc3VlQ29tbWVudDgzMzc1MzI1Ng== andersy005 13301940 2021-05-06T18:19:41Z 2021-05-06T18:19:41Z MEMBER

Never mind... There's a bug in this if

https://github.com/pydata/xarray/blob/01c1d25578634306b5d3179989a0a9bd867de176/.github/workflows/pypi-release.yaml#L84

It should be github.ref instead of github.event.ref... Opening a PR shortly (not sure if you still want to use the GitHub action)... 

{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   release v0.18.0 870292042
833741743 https://github.com/pydata/xarray/issues/5232#issuecomment-833741743 https://api.github.com/repos/pydata/xarray/issues/5232 MDEyOklzc3VlQ29tbWVudDgzMzc0MTc0Mw== andersy005 13301940 2021-05-06T18:03:01Z 2021-05-06T18:03:13Z MEMBER

Hmm... Looks like it built but didn't upload: pydata/xarray/runs/2520588073?check_suite_focus=true

cc @keewis @andersy005

Sorry about that. I think the culprit here are the if conditions which evaluate to false on release events... @keewis what do you think? :)

https://github.com/pydata/xarray/blob/01c1d25578634306b5d3179989a0a9bd867de176/.github/workflows/pypi-release.yaml#L66

https://github.com/pydata/xarray/blob/01c1d25578634306b5d3179989a0a9bd867de176/.github/workflows/pypi-release.yaml#L75

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   release v0.18.0 870292042

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);