issue_comments

Table actions

8 rows where issue = 867046262 sorted by updated_at descending

✖
✖

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

author_association 3

issue 1

  • Enable using __setitem__ for Dataset using a list as key · 8 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
830867253 https://github.com/pydata/xarray/pull/5216#issuecomment-830867253 https://api.github.com/repos/pydata/xarray/issues/5216 MDEyOklzc3VlQ29tbWVudDgzMDg2NzI1Mw== max-sixty 5635139 2021-05-02T20:30:26Z 2021-05-02T20:30:26Z MEMBER

@gcaria thanks a lot for the code and your patience working through the comments! We're very happy to have you as a contributor

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Enable using __setitem__ for Dataset using a list as key 867046262
830237550 https://github.com/pydata/xarray/pull/5216#issuecomment-830237550 https://api.github.com/repos/pydata/xarray/issues/5216 MDEyOklzc3VlQ29tbWVudDgzMDIzNzU1MA== pep8speaks 24736507 2021-04-30T17:11:59Z 2021-05-02T19:15:43Z NONE

Hello @gcaria! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! :beers:

Comment last updated at 2021-05-02 19:15:43 UTC
 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Enable using __setitem__ for Dataset using a list as key 867046262
830657777 https://github.com/pydata/xarray/pull/5216#issuecomment-830657777 https://api.github.com/repos/pydata/xarray/issues/5216 MDEyOklzc3VlQ29tbWVudDgzMDY1Nzc3Nw== gcaria 44147817 2021-05-01T16:27:13Z 2021-05-01T16:27:13Z CONTRIBUTOR

Thanks all for the feedback ! This thread it's getting a bit hard to follow, but I believe this is the only suggested change that I haven't applied https://github.com/pydata/xarray/pull/5216#discussion_r624062989

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Enable using __setitem__ for Dataset using a list as key 867046262
830420928 https://github.com/pydata/xarray/pull/5216#issuecomment-830420928 https://api.github.com/repos/pydata/xarray/issues/5216 MDEyOklzc3VlQ29tbWVudDgzMDQyMDkyOA== mathause 10194086 2021-04-30T21:53:29Z 2021-04-30T21:53:29Z MEMBER

thanks for the info, hadn't seen that one.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Enable using __setitem__ for Dataset using a list as key 867046262
830395455 https://github.com/pydata/xarray/pull/5216#issuecomment-830395455 https://api.github.com/repos/pydata/xarray/issues/5216 MDEyOklzc3VlQ29tbWVudDgzMDM5NTQ1NQ== keewis 14808389 2021-04-30T21:09:45Z 2021-04-30T21:09:45Z MEMBER

github had trouble with people abusing the "run actions on PRs" feature (namely, it was used to mine cryptocurrencies) so they now require a maintainer to approve every new commit on a first time contributor's PR (for maintainers there's a "Approve and run" button directly above the merge button)

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Enable using __setitem__ for Dataset using a list as key 867046262
829445870 https://github.com/pydata/xarray/pull/5216#issuecomment-829445870 https://api.github.com/repos/pydata/xarray/issues/5216 MDEyOklzc3VlQ29tbWVudDgyOTQ0NTg3MA== max-sixty 5635139 2021-04-29T17:19:55Z 2021-04-29T17:19:55Z MEMBER

Great — @gcaria if you're OK to hit the "Commit suggestion" on those then we can merge?

Thanks for the review @mathause 

{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Enable using __setitem__ for Dataset using a list as key 867046262
827072426 https://github.com/pydata/xarray/pull/5216#issuecomment-827072426 https://api.github.com/repos/pydata/xarray/issues/5216 MDEyOklzc3VlQ29tbWVudDgyNzA3MjQyNg== max-sixty 5635139 2021-04-26T18:59:49Z 2021-04-26T18:59:49Z MEMBER

Great @gcaria ! And thanks for the issue link.

Unless we hear from others, we can merge in the next couple of days. Could we add a test for the ds rvalue and a whatsnew?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Enable using __setitem__ for Dataset using a list as key 867046262
826376063 https://github.com/pydata/xarray/pull/5216#issuecomment-826376063 https://api.github.com/repos/pydata/xarray/issues/5216 MDEyOklzc3VlQ29tbWVudDgyNjM3NjA2Mw== max-sixty 5635139 2021-04-25T19:22:07Z 2021-04-25T19:22:07Z MEMBER

I think this is a good feature — any thoughts from others? Should a dataset be a valid rvalue?

I added some comments @gcaria . Great to have you as a contributor. We could add a line or two in the docs, and whatsnew. And you're right — the tests could be filled out a bit (no need to go overboard though).

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Enable using __setitem__ for Dataset using a list as key 867046262

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);