issue_comments

Table actions

8 rows where issue = 863506023 and user = 12912489 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

user 1

  • SimonHeybrock · 8 ✖

issue 1

  • Fix lag in Jupyter caused by CSS in `_repr_html_` · 8 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
872054936 https://github.com/pydata/xarray/pull/5201#issuecomment-872054936 https://api.github.com/repos/pydata/xarray/issues/5201 MDEyOklzc3VlQ29tbWVudDg3MjA1NDkzNg== SimonHeybrock 12912489 2021-07-01T08:49:04Z 2021-07-01T08:49:04Z NONE

Before:

After:

On the top band, I have used the screenshot-timeline to zoom onto the time window where the cell is being executed (marked with [*]), before the new output is displayed. You should be able to see that the time-scale is bastly different. 

{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix lag in Jupyter caused by CSS in `_repr_html_` 863506023
872037862 https://github.com/pydata/xarray/pull/5201#issuecomment-872037862 https://api.github.com/repos/pydata/xarray/issues/5201 MDEyOklzc3VlQ29tbWVudDg3MjAzNzg2Mg== SimonHeybrock 12912489 2021-07-01T08:25:12Z 2021-07-01T08:25:12Z NONE

Maybe can we measure the first-loading time? I observe the first-loading time is very long...

I think this is also a problem, but I believe this is independent and not improved by the CSS changes in this branch. Maybe a Jupyter issue and not related to libraries in use?

The only way I was able to see it was to use the Web Dev tools that come as part of Firefox or Chrome.

Can you tell me more about this? I'll try to reproduce and measure the performance.

So I had used Chrome, open "Developer Tools" > "Performance" tab: - start recording a profile - run a cell the displays HTML output - stop profile

I think I had observed a difference in the "Render" part of the profile, but I cannot check now (I may be able later today when I am back to my main computer).

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix lag in Jupyter caused by CSS in `_repr_html_` 863506023
872013761 https://github.com/pydata/xarray/pull/5201#issuecomment-872013761 https://api.github.com/repos/pydata/xarray/issues/5201 MDEyOklzc3VlQ29tbWVudDg3MjAxMzc2MQ== SimonHeybrock 12912489 2021-07-01T07:54:15Z 2021-07-01T07:54:15Z NONE

Indeed, such timings do not include the CSS timings. The only way I was able to see it was to use the Web Dev tools that come as part of Firefox or Chrome. You should be able to see the timings included there when recording a profile.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix lag in Jupyter caused by CSS in `_repr_html_` 863506023
871996744 https://github.com/pydata/xarray/pull/5201#issuecomment-871996744 https://api.github.com/repos/pydata/xarray/issues/5201 MDEyOklzc3VlQ29tbWVudDg3MTk5Njc0NA== SimonHeybrock 12912489 2021-07-01T07:26:50Z 2021-07-01T07:26:50Z NONE

@fujiisoup Maybe I missed it in the video, but did you try if there are differences when running an individual cell, not just when loading the page the first time? My point is: - When a page is first loaded, obviously the CSS for everything (all cells) has to be processed. That cannot be changed. - When updated a single cell, prior to this branch, it triggered CSS changes for all cells. - With this branch, only current cell should be affected.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix lag in Jupyter caused by CSS in `_repr_html_` 863506023
828259218 https://github.com/pydata/xarray/pull/5201#issuecomment-828259218 https://api.github.com/repos/pydata/xarray/issues/5201 MDEyOklzc3VlQ29tbWVudDgyODI1OTIxOA== SimonHeybrock 12912489 2021-04-28T08:27:14Z 2021-04-28T08:27:14Z NONE

Or not quite: The DOM seems to end at editor-instance, which is the whole Jupyter part of the Window. I cannot seem to access anything below that using the Developer Tools.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix lag in Jupyter caused by CSS in `_repr_html_` 863506023
828236723 https://github.com/pydata/xarray/pull/5201#issuecomment-828236723 https://api.github.com/repos/pydata/xarray/issues/5201 MDEyOklzc3VlQ29tbWVudDgyODIzNjcyMw== SimonHeybrock 12912489 2021-04-28T07:55:23Z 2021-04-28T07:55:23Z NONE

Cheers, that was what I was looking for!

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix lag in Jupyter caused by CSS in `_repr_html_` 863506023
828216637 https://github.com/pydata/xarray/pull/5201#issuecomment-828216637 https://api.github.com/repos/pydata/xarray/issues/5201 MDEyOklzc3VlQ29tbWVudDgyODIxNjYzNw== SimonHeybrock 12912489 2021-04-28T07:26:41Z 2021-04-28T07:28:06Z NONE

Ok, I tried, but got stuck: I can reproduce the issue in VScode. However, I cannot find a way to inspect the CSS in VScode's Jupyter console. The theme itself is a json and I cannot figure how this is translated into CSS.

We somehow need to detect the theme within xr-wrap and change colors accordingly. That would require checking if a parent/grandparent/... is something defined by VScode, or by checking if custom properties exist. Does someone know how to access the actual HTML/CSS in VScode? In a normal notebook I can use, e.g., the Firefox web-dev tools to do this directly in the browser, but I cannot find anything equivalent in VScode.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix lag in Jupyter caused by CSS in `_repr_html_` 863506023
826492174 https://github.com/pydata/xarray/pull/5201#issuecomment-826492174 https://api.github.com/repos/pydata/xarray/issues/5201 MDEyOklzc3VlQ29tbWVudDgyNjQ5MjE3NA== SimonHeybrock 12912489 2021-04-26T04:29:00Z 2021-04-26T04:29:00Z NONE

I don't have VS code so I can't try, but looking at the CSS I feel that this would actually break the colors there, since I moved the general settings from root into xr-wrap, below the level where the vscode-dark settings are defined. I don't know how to fix this though.

So I would recommend not to merge this unless someone is able to try it out.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix lag in Jupyter caused by CSS in `_repr_html_` 863506023

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);