home / github

Menu
  • GraphQL API
  • Search all tables

issue_comments

Table actions
  • GraphQL API for issue_comments

3 rows where issue = 862107086 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

user 3

  • max-sixty 1
  • keewis 1
  • pep8speaks 1

author_association 2

  • MEMBER 2
  • NONE 1

issue 1

  • Remove final raises_regexes · 3 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
824223959 https://github.com/pydata/xarray/pull/5191#issuecomment-824223959 https://api.github.com/repos/pydata/xarray/issues/5191 MDEyOklzc3VlQ29tbWVudDgyNDIyMzk1OQ== max-sixty 5635139 2021-04-21T17:14:00Z 2021-04-21T19:04:00Z MEMBER

I'll merge this so we put raises_regex to rest, and keep an eye on the scipy issue.

If others have used raises_regex, we may get some failures on merging their branch. The easiest approach is to merge master into their branch such that raises_regex fails and requires replacing. But if we make a mistake and merge, it's easy to fix, I'll try and spot it early.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  Remove final raises_regexes 862107086
823260631 https://github.com/pydata/xarray/pull/5191#issuecomment-823260631 https://api.github.com/repos/pydata/xarray/issues/5191 MDEyOklzc3VlQ29tbWVudDgyMzI2MDYzMQ== keewis 14808389 2021-04-20T13:09:30Z 2021-04-20T13:35:29Z MEMBER

this seems to be something in pytest.raises: python with pytest.raises(error) as excinfo: ... behaves different from python with pytest.raises(error): ... so the test will pass for the former but not the latter.

Actually, I can reproduce without involving open_dataset (or xarray) at all: replacing it with calls to open_ will still close and show the exact same behavior. For reference, this will fail on the second assert: ```python import pytest import scipy.io

def open_(f): return scipy.io.netcdf_file(f, mode="r", version=2)

def test_open(): filename = "file.nc" with open(filename, mode="w") as f: f.write("abcdefghijklmnopqrstuvwxyz")

with open(filename, mode="rb") as f:
    with pytest.raises(TypeError) as excinfo:
        open_(f)
    assert not f.closed, "first file closed"

with open(filename, mode="rb") as f:
    with pytest.raises(TypeError):
        open_(f)
    assert not f.closed, "second file closed"

```

Edit: I tried asking the scipy devs, see scipy/scipy#13905

{
    "total_count": 2,
    "+1": 2,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  Remove final raises_regexes 862107086
822861343 https://github.com/pydata/xarray/pull/5191#issuecomment-822861343 https://api.github.com/repos/pydata/xarray/issues/5191 MDEyOklzc3VlQ29tbWVudDgyMjg2MTM0Mw== pep8speaks 24736507 2021-04-19T23:46:45Z 2021-04-19T23:46:45Z NONE

Hello @max-sixty! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

  • In the file xarray/tests/__init__.py:

Line 3:1: F401 're' imported but unused

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  Remove final raises_regexes 862107086

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options:

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);
Powered by Datasette · Queries took 12.467ms · About: xarray-datasette