issue_comments

Table actions

8 rows where issue = 860711833 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

author_association 3

issue 1

  • Support ffill and bfill along chunked dimensions · 8 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
826027314 https://github.com/pydata/xarray/pull/5187#issuecomment-826027314 https://api.github.com/repos/pydata/xarray/issues/5187 MDEyOklzc3VlQ29tbWVudDgyNjAyNzMxNA== jrbourbeau 11656932 2021-04-24T03:34:23Z 2021-04-24T03:34:23Z CONTRIBUTOR

Yeah, sorry about that. At least it was an easy fix : ) 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Support ffill and bfill along chunked dimensions 860711833
826027129 https://github.com/pydata/xarray/pull/5187#issuecomment-826027129 https://api.github.com/repos/pydata/xarray/issues/5187 MDEyOklzc3VlQ29tbWVudDgyNjAyNzEyOQ== dcherian 2448579 2021-04-24T03:32:35Z 2021-04-24T03:32:35Z MEMBER

@jrbourbeau thanks! It looks like it is working. Very unfortunate timing! 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Support ffill and bfill along chunked dimensions 860711833
826025127 https://github.com/pydata/xarray/pull/5187#issuecomment-826025127 https://api.github.com/repos/pydata/xarray/issues/5187 MDEyOklzc3VlQ29tbWVudDgyNjAyNTEyNw== jrbourbeau 11656932 2021-04-24T03:10:54Z 2021-04-24T03:10:54Z CONTRIBUTOR

@dcherian could you try restarting CI to pull in the latest dask release? xref https://github.com/dask/community/issues/150#issuecomment-826025006

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Support ffill and bfill along chunked dimensions 860711833
826022833 https://github.com/pydata/xarray/pull/5187#issuecomment-826022833 https://api.github.com/repos/pydata/xarray/issues/5187 MDEyOklzc3VlQ29tbWVudDgyNjAyMjgzMw== dcherian 2448579 2021-04-24T02:49:31Z 2021-04-24T02:52:40Z MEMBER

failures are unrelated

commented here: https://github.com/dask/community/issues/150

python FAILED xarray/tests/test_distributed.py::test_dask_distributed_netcdf_roundtrip[netcdf4-NETCDF3_CLASSIC] FAILED xarray/tests/test_distributed.py::test_dask_distributed_netcdf_roundtrip[netcdf4-NETCDF4_CLASSIC] FAILED xarray/tests/test_distributed.py::test_dask_distributed_netcdf_roundtrip[netcdf4-NETCDF4] FAILED xarray/tests/test_distributed.py::test_dask_distributed_netcdf_roundtrip[h5netcdf-NETCDF4] FAILED xarray/tests/test_distributed.py::test_dask_distributed_read_netcdf_integration_test[netcdf4-NETCDF3_CLASSIC] FAILED xarray/tests/test_distributed.py::test_dask_distributed_read_netcdf_integration_test[netcdf4-NETCDF4] FAILED xarray/tests/test_distributed.py::test_dask_distributed_read_netcdf_integration_test[h5netcdf-NETCDF4] FAILED xarray/tests/test_distributed.py::test_dask_distributed_read_netcdf_integration_test[scipy-NETCDF3_64BIT] FAILED xarray/tests/test_distributed.py::test_dask_distributed_zarr_integration_test[True-True] FAILED xarray/tests/test_distributed.py::test_dask_distributed_zarr_integration_test[True-False] FAILED xarray/tests/test_distributed.py::test_dask_distributed_zarr_integration_test[False-True] FAILED xarray/tests/test_distributed.py::test_dask_distributed_zarr_integration_test[False-False] FAILED xarray/tests/test_distributed.py::test_dask_distributed_rasterio_integration_test FAILED xarray/tests/test_distributed.py::test_dask_distributed_cfgrib_integration_test FAILED xarray/tests/test_distributed.py::test_async - ImportError: cannot imp... FAILED xarray/tests/test_distributed.py::test_serializable_locks - ImportErro...

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Support ffill and bfill along chunked dimensions 860711833
826020951 https://github.com/pydata/xarray/pull/5187#issuecomment-826020951 https://api.github.com/repos/pydata/xarray/issues/5187 MDEyOklzc3VlQ29tbWVudDgyNjAyMDk1MQ== dcherian 2448579 2021-04-24T02:32:26Z 2021-04-24T02:32:26Z MEMBER

looks good to me, although I would probably move the dask implementation to dask_array_ops.

Good idea. Done!

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Support ffill and bfill along chunked dimensions 860711833
823637932 https://github.com/pydata/xarray/pull/5187#issuecomment-823637932 https://api.github.com/repos/pydata/xarray/issues/5187 MDEyOklzc3VlQ29tbWVudDgyMzYzNzkzMg== pep8speaks 24736507 2021-04-20T22:24:23Z 2021-04-24T02:32:02Z NONE

Hello @dcherian! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! :beers:

Comment last updated at 2021-04-24 02:32:02 UTC
 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Support ffill and bfill along chunked dimensions 860711833
824147484 https://github.com/pydata/xarray/pull/5187#issuecomment-824147484 https://api.github.com/repos/pydata/xarray/issues/5187 MDEyOklzc3VlQ29tbWVudDgyNDE0NzQ4NA== dcherian 2448579 2021-04-21T15:20:48Z 2021-04-21T15:20:48Z MEMBER

Thanks for the reviews. I'll merge in a couple of days if there are no comments.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Support ffill and bfill along chunked dimensions 860711833
822031614 https://github.com/pydata/xarray/pull/5187#issuecomment-822031614 https://api.github.com/repos/pydata/xarray/issues/5187 MDEyOklzc3VlQ29tbWVudDgyMjAzMTYxNA== max-sixty 5635139 2021-04-18T17:51:29Z 2021-04-18T17:51:29Z MEMBER

Looks good — though I don't know the dask interface that well. The tests look good though.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Support ffill and bfill along chunked dimensions 860711833

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);