issue_comments

Table actions

13 rows where issue = 860073545 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

author_association 3

issue 1

  • Enable __setitem__ for dask versions that support it. · 13 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
830686289 https://github.com/pydata/xarray/pull/5174#issuecomment-830686289 https://api.github.com/repos/pydata/xarray/issues/5174 MDEyOklzc3VlQ29tbWVudDgzMDY4NjI4OQ== max-sixty 5635139 2021-05-01T19:59:31Z 2021-05-01T19:59:31Z MEMBER

Excellent — thank you @tammasloughran ! 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Enable __setitem__ for dask versions that support it. 860073545
821432500 https://github.com/pydata/xarray/pull/5174#issuecomment-821432500 https://api.github.com/repos/pydata/xarray/issues/5174 MDEyOklzc3VlQ29tbWVudDgyMTQzMjUwMA== pep8speaks 24736507 2021-04-16T18:33:33Z 2021-05-01T11:11:23Z NONE

Hello @tammasloughran! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! :beers:

Comment last updated at 2021-05-01 11:11:23 UTC
 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Enable __setitem__ for dask versions that support it. 860073545
830433663 https://github.com/pydata/xarray/pull/5174#issuecomment-830433663 https://api.github.com/repos/pydata/xarray/issues/5174 MDEyOklzc3VlQ29tbWVudDgzMDQzMzY2Mw== max-sixty 5635139 2021-04-30T22:27:23Z 2021-04-30T22:27:23Z MEMBER

@tammasloughran this just needs a whatsnew now!

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Enable __setitem__ for dask versions that support it. 860073545
830391695 https://github.com/pydata/xarray/pull/5174#issuecomment-830391695 https://api.github.com/repos/pydata/xarray/issues/5174 MDEyOklzc3VlQ29tbWVudDgzMDM5MTY5NQ== keewis 14808389 2021-04-30T21:05:09Z 2021-04-30T21:05:09Z MEMBER

A dask method __dask_distributed_pack__ is complaining:

that seems to have been a conda issue (but it's gone now), and the remaining failure is a known flaky test, so CI looks good

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Enable __setitem__ for dask versions that support it. 860073545
830287979 https://github.com/pydata/xarray/pull/5174#issuecomment-830287979 https://api.github.com/repos/pydata/xarray/issues/5174 MDEyOklzc3VlQ29tbWVudDgzMDI4Nzk3OQ== Illviljan 14371165 2021-04-30T18:40:58Z 2021-04-30T18:40:58Z MEMBER

The errors seems unrelated? Seems to rather be a mismatch in the CI?

A dask method __dask_distributed_pack__ is complaining: ```

  from distributed.protocol.core import dumps_msgpack

E ImportError: cannot import name 'dumps_msgpack' from 'distributed.protocol.core' (/usr/share/miniconda/envs/xarray-tests/lib ``` But those seems to have been removed in https://github.com/dask/distributed/pull/4677. Further reading in https://github.com/dask/dask-yarn/issues/147#issuecomment-829265029

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Enable __setitem__ for dask versions that support it. 860073545
830238152 https://github.com/pydata/xarray/pull/5174#issuecomment-830238152 https://api.github.com/repos/pydata/xarray/issues/5174 MDEyOklzc3VlQ29tbWVudDgzMDIzODE1Mg== max-sixty 5635139 2021-04-30T17:13:07Z 2021-04-30T17:13:07Z MEMBER

@tammasloughran would be great to get this in by https://github.com/pydata/xarray/issues/5232 if you have any time, it's great work. I think it's fairly close to the tests passing.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Enable __setitem__ for dask versions that support it. 860073545
824241591 https://github.com/pydata/xarray/pull/5174#issuecomment-824241591 https://api.github.com/repos/pydata/xarray/issues/5174 MDEyOklzc3VlQ29tbWVudDgyNDI0MTU5MQ== max-sixty 5635139 2021-04-21T17:43:51Z 2021-04-21T17:43:51Z MEMBER

After those two suggestions, let's merge?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Enable __setitem__ for dask versions that support it. 860073545
822712358 https://github.com/pydata/xarray/pull/5174#issuecomment-822712358 https://api.github.com/repos/pydata/xarray/issues/5174 MDEyOklzc3VlQ29tbWVudDgyMjcxMjM1OA== dcherian 2448579 2021-04-19T19:07:05Z 2021-04-19T19:07:05Z MEMBER

I see now there is also a duplicate test here, which fails when using the newer dask version. I

That's testing the Variable object which is the lowest-level Xarray object. It would be a good place to add the assignment tests

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Enable __setitem__ for dask versions that support it. 860073545
822700398 https://github.com/pydata/xarray/pull/5174#issuecomment-822700398 https://api.github.com/repos/pydata/xarray/issues/5174 MDEyOklzc3VlQ29tbWVudDgyMjcwMDM5OA== tammasloughran 9049976 2021-04-19T18:56:27Z 2021-04-19T18:57:00Z CONTRIBUTOR

I don't quite understand understand what you mean. Like this?

Forgive me not being clear. The current test with the version check is great. And I hadn't realized there was a released dask version — even better that the test is already running on both versions of the code.

Well... I see now there is also a duplicate test here, which fails when using the newer dask version. I don't understand why xarray goes to all the trouble of directly unit testing an external library. Makes more sense to me to only test the xarray wrapper for the dask functionality. I could add another version check there, or remove that test. What do you think?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Enable __setitem__ for dask versions that support it. 860073545
822656799 https://github.com/pydata/xarray/pull/5174#issuecomment-822656799 https://api.github.com/repos/pydata/xarray/issues/5174 MDEyOklzc3VlQ29tbWVudDgyMjY1Njc5OQ== dcherian 2448579 2021-04-19T17:48:56Z 2021-04-19T17:48:56Z MEMBER

Thanks @tammasloughran This is a great PR!

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Enable __setitem__ for dask versions that support it. 860073545
822460282 https://github.com/pydata/xarray/pull/5174#issuecomment-822460282 https://api.github.com/repos/pydata/xarray/issues/5174 MDEyOklzc3VlQ29tbWVudDgyMjQ2MDI4Mg== max-sixty 5635139 2021-04-19T13:19:05Z 2021-04-19T13:19:05Z MEMBER

I don't quite understand understand what you mean. Like this?

Forgive me not being clear. The current test with the version check is great. And I hadn't realized there was a released dask version — even better that the test is already running on both versions of the code.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Enable __setitem__ for dask versions that support it. 860073545
822380259 https://github.com/pydata/xarray/pull/5174#issuecomment-822380259 https://api.github.com/repos/pydata/xarray/issues/5174 MDEyOklzc3VlQ29tbWVudDgyMjM4MDI1OQ== tammasloughran 9049976 2021-04-19T11:01:33Z 2021-04-19T11:01:33Z CONTRIBUTOR

Are there any current tests for the error that break on the new version (i.e. because it doesn't raise an error)?

I don't quite understand understand what you mean. Like this?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Enable __setitem__ for dask versions that support it. 860073545
821563673 https://github.com/pydata/xarray/pull/5174#issuecomment-821563673 https://api.github.com/repos/pydata/xarray/issues/5174 MDEyOklzc3VlQ29tbWVudDgyMTU2MzY3Mw== max-sixty 5635139 2021-04-16T21:04:52Z 2021-04-16T21:04:52Z MEMBER

Looks good! Not sure whether there's a reasonable way of testing this...

Are there any current tests for the error that break on the new version (i.e. because it doesn't raise an error)?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Enable __setitem__ for dask versions that support it. 860073545

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);