issue_comments

Table actions

8 rows where issue = 849974334 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 3

issue 1

  • Move mypy configs from pre-commit to mypy config · 8 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
819682939 https://github.com/pydata/xarray/pull/5110#issuecomment-819682939 https://api.github.com/repos/pydata/xarray/issues/5110 MDEyOklzc3VlQ29tbWVudDgxOTY4MjkzOQ== max-sixty 5635139 2021-04-14T17:15:43Z 2021-04-14T17:15:43Z MEMBER

pre-commit does not create a full environment before running mypy, which means that it can't check using external type hints (like the ones from numpy). See #4881 for more explanation.

Thanks! I added a link to that for future travelers

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Move mypy configs from pre-commit to mypy config 849974334
819656693 https://github.com/pydata/xarray/pull/5110#issuecomment-819656693 https://api.github.com/repos/pydata/xarray/issues/5110 MDEyOklzc3VlQ29tbWVudDgxOTY1NjY5Mw== keewis 14808389 2021-04-14T16:35:25Z 2021-04-14T16:35:25Z MEMBER

Why do we have that as well as ci-pre-commit.yaml?

pre-commit does not create a full environment before running mypy, which means that it can't check using external type hints (like the ones from numpy). See #4881 for more explanation.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Move mypy configs from pre-commit to mypy config 849974334
818331126 https://github.com/pydata/xarray/pull/5110#issuecomment-818331126 https://api.github.com/repos/pydata/xarray/issues/5110 MDEyOklzc3VlQ29tbWVudDgxODMzMTEyNg== max-sixty 5635139 2021-04-13T00:26:18Z 2021-04-13T00:26:18Z MEMBER

could you change the call in the mypy CI to use python -m mypy . (so we can verify this works)?

Great done.

I didn't know about that. Why do we have that as well as ci-pre-commit.yaml?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Move mypy configs from pre-commit to mypy config 849974334
818012870 https://github.com/pydata/xarray/pull/5110#issuecomment-818012870 https://api.github.com/repos/pydata/xarray/issues/5110 MDEyOklzc3VlQ29tbWVudDgxODAxMjg3MA== keewis 14808389 2021-04-12T18:01:19Z 2021-04-12T18:01:19Z MEMBER

could you change the call in the mypy CI to use python -m mypy . (so we can verify this works)?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Move mypy configs from pre-commit to mypy config 849974334
817440782 https://github.com/pydata/xarray/pull/5110#issuecomment-817440782 https://api.github.com/repos/pydata/xarray/issues/5110 MDEyOklzc3VlQ29tbWVudDgxNzQ0MDc4Mg== max-sixty 5635139 2021-04-12T02:43:39Z 2021-04-12T02:56:41Z MEMBER

I think this should now work! TIL toml doesn't have quotations for strings

We still need the entry in .pre-commit-config.yaml, but at least mypy . works now.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Move mypy configs from pre-commit to mypy config 849974334
814262315 https://github.com/pydata/xarray/pull/5110#issuecomment-814262315 https://api.github.com/repos/pydata/xarray/issues/5110 MDEyOklzc3VlQ29tbWVudDgxNDI2MjMxNQ== shoyer 1217238 2021-04-06T16:34:14Z 2021-04-06T16:34:14Z MEMBER

Maybe the recommended command should be mypy xarray?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Move mypy configs from pre-commit to mypy config 849974334
813308181 https://github.com/pydata/xarray/pull/5110#issuecomment-813308181 https://api.github.com/repos/pydata/xarray/issues/5110 MDEyOklzc3VlQ29tbWVudDgxMzMwODE4MQ== keewis 14808389 2021-04-05T09:44:28Z 2021-04-05T09:44:28Z MEMBER

in order to get this to work you would need to add empty __init__.py to asv_bench and properties. Not sure if we would then need to modify the packaging configuration, though.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Move mypy configs from pre-commit to mypy config 849974334
813110869 https://github.com/pydata/xarray/pull/5110#issuecomment-813110869 https://api.github.com/repos/pydata/xarray/issues/5110 MDEyOklzc3VlQ29tbWVudDgxMzExMDg2OQ== max-sixty 5635139 2021-04-04T22:48:06Z 2021-04-04T22:48:06Z MEMBER

This doesn't seem to work:

conftest.py: error: Duplicate module named 'conftest' (also at './properties/conftest.py') conftest.py: note: Are you missing an __init__.py? Alternatively, consider using --exclude to avoid checking one of them. Found 1 error in 1 file (errors prevented further checking)

Not sure exactly why it doesn't ignore the errors given the configs.

I'll close this unless anyone has ideas.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Move mypy configs from pre-commit to mypy config 849974334

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);