issue_comments

Table actions

2 rows where issue = 847014702 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 2

author_association 2

issue 1

  • open_dataset regression · 2 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
812453263 https://github.com/pydata/xarray/issues/5098#issuecomment-812453263 https://api.github.com/repos/pydata/xarray/issues/5098 MDEyOklzc3VlQ29tbWVudDgxMjQ1MzI2Mw== alexamici 226037 2021-04-02T09:33:24Z 2021-04-02T09:33:43Z MEMBER

The reason to delegate all path normalisation to backends is that not all strings are paths, for example 'NETCDF:"~/sst.nc":tos' is a valid source string for GDAL / rasterio.

I would suggest to add path normalisation to the backends that needs them, in order to avoid any special case in the common code path.

@aurghs I suggest you add os.path.expanduser in the netCDF backend.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   open_dataset regression 847014702
811820701 https://github.com/pydata/xarray/issues/5098#issuecomment-811820701 https://api.github.com/repos/pydata/xarray/issues/5098 MDEyOklzc3VlQ29tbWVudDgxMTgyMDcwMQ== aurghs 35919497 2021-04-01T10:40:37Z 2021-04-01T10:41:44Z COLLABORATOR

I think that this is consequence of the refactor done by @alexamici when he has removed _normalize_path: https://github.com/pydata/xarray/pull/4701 We decided to demand the path interpretation to the backends.

I'll have a look to understand how to fix it. 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   open_dataset regression 847014702

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);