issue_comments

Table actions

1 row where issue = 842583817 and user = 3958036 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 1

  • johnomotani · 1 ✖

issue 1

  • plot_surface() wrapper · 1 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
811261936 https://github.com/pydata/xarray/issues/5084#issuecomment-811261936 https://api.github.com/repos/pydata/xarray/issues/5084 MDEyOklzc3VlQ29tbWVudDgxMTI2MTkzNg== johnomotani 3958036 2021-03-31T17:12:23Z 2021-03-31T17:12:23Z CONTRIBUTOR

I started working on this, and it seems to be almost trivial, except that plot_surface() requires it's x and y arguments to be 2d arrays. My guess is that I want to special-case the broadcasting in newplotfunc() here https://github.com/pydata/xarray/blob/ddc352faa6de91f266a1749773d08ae8d6f09683/xarray/plot/plot.py#L678-L684 but it's not immediately obvious to me how this bit works: * Why is it only ever xval that needs broadcasting? Couldn't the function have been called with a 2d x and a 1d y? * Why is it OK to check if xval.shape[0] == yval.shape[0]? I'm probably missing something, but don't see how this check can work without referring to the actual dimensions of x and y - what if the single dimension of x was actually the second dimension of y, but happened to have the same size as the first dimension of y? My first thought was that I just want to do x = x.broadcast_like(z) y = y.broadcast_like(z) actually, I think this is a bug. I'll make a new issue...

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   plot_surface() wrapper 842583817

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);