issue_comments

Table actions

8 rows where issue = 842535132 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

author_association 3

issue 1

  • Disable the cfgrib backend if eccodes is not installed · 8 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
810383977 https://github.com/pydata/xarray/pull/5083#issuecomment-810383977 https://api.github.com/repos/pydata/xarray/issues/5083 MDEyOklzc3VlQ29tbWVudDgxMDM4Mzk3Nw== mathause 10194086 2021-03-30T16:01:30Z 2021-03-30T16:01:30Z MEMBER

No worries, that was actually quite fast. Thanks a lot for your contribution @b8raoult - welcome to xarray.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Disable the cfgrib backend if eccodes is not installed 842535132
809330908 https://github.com/pydata/xarray/pull/5083#issuecomment-809330908 https://api.github.com/repos/pydata/xarray/issues/5083 MDEyOklzc3VlQ29tbWVudDgwOTMzMDkwOA== pep8speaks 24736507 2021-03-29T12:17:59Z 2021-03-30T15:59:59Z NONE

Hello @b8raoult! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! :beers:

Comment last updated at 2021-03-30 15:59:59 UTC
 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Disable the cfgrib backend if eccodes is not installed 842535132
810349638 https://github.com/pydata/xarray/pull/5083#issuecomment-810349638 https://api.github.com/repos/pydata/xarray/issues/5083 MDEyOklzc3VlQ29tbWVudDgxMDM0OTYzOA== b8raoult 53792887 2021-03-30T15:20:34Z 2021-03-30T15:20:34Z CONTRIBUTOR

Sorry @mathause if I am a bit slow, this is my first pull request :-)

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Disable the cfgrib backend if eccodes is not installed 842535132
809967351 https://github.com/pydata/xarray/pull/5083#issuecomment-809967351 https://api.github.com/repos/pydata/xarray/issues/5083 MDEyOklzc3VlQ29tbWVudDgwOTk2NzM1MQ== mathause 10194086 2021-03-30T07:02:08Z 2021-03-30T07:02:08Z MEMBER

Thanks for the quick feedback. I think that's ready to merge then.

@b8raoult do you want to give yourself credit in whats-new? 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Disable the cfgrib backend if eccodes is not installed 842535132
809688189 https://github.com/pydata/xarray/pull/5083#issuecomment-809688189 https://api.github.com/repos/pydata/xarray/issues/5083 MDEyOklzc3VlQ29tbWVudDgwOTY4ODE4OQ== alexamici 226037 2021-03-29T20:26:02Z 2021-03-29T20:57:17Z MEMBER

@keewis @mathause and @b8raoult the change looks good to me.

Non-conda users may very well hit the RuntimeError and xarray should not fail to load in that case, but throwing a the warning looks sensible to me.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Disable the cfgrib backend if eccodes is not installed 842535132
809643317 https://github.com/pydata/xarray/pull/5083#issuecomment-809643317 https://api.github.com/repos/pydata/xarray/issues/5083 MDEyOklzc3VlQ29tbWVudDgwOTY0MzMxNw== keewis 14808389 2021-03-29T19:17:47Z 2021-03-29T19:17:47Z MEMBER

not sure. Warning about incompatible / incomplete installations should be fine and the message looks good, but I know next to nothing about cfgrib. @alexamici, would you as a cfgrib maintainer have any comments?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Disable the cfgrib backend if eccodes is not installed 842535132
809283647 https://github.com/pydata/xarray/pull/5083#issuecomment-809283647 https://api.github.com/repos/pydata/xarray/issues/5083 MDEyOklzc3VlQ29tbWVudDgwOTI4MzY0Nw== keewis 14808389 2021-03-29T10:54:29Z 2021-03-29T10:54:29Z MEMBER

you seem to have marked the conversation as "resolved". If you want to accept the suggestions you need to use the Commit suggestion button

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Disable the cfgrib backend if eccodes is not installed 842535132
809265666 https://github.com/pydata/xarray/pull/5083#issuecomment-809265666 https://api.github.com/repos/pydata/xarray/issues/5083 MDEyOklzc3VlQ29tbWVudDgwOTI2NTY2Ng== b8raoult 53792887 2021-03-29T10:24:25Z 2021-03-29T10:24:25Z CONTRIBUTOR

I am new to GitHub. Not sure I did the right thing to accept the suggested changes

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Disable the cfgrib backend if eccodes is not installed 842535132

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);