issue_comments

Table actions

3 rows where issue = 839823306 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

author_association 2

issue 1

  • requires io.IOBase subclass rather than duck file-like · 3 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
809493007 https://github.com/pydata/xarray/issues/5070#issuecomment-809493007 https://api.github.com/repos/pydata/xarray/issues/5070 MDEyOklzc3VlQ29tbWVudDgwOTQ5MzAwNw== martindurant 6042212 2021-03-29T15:52:28Z 2021-03-29T15:52:28Z CONTRIBUTOR

Unsure whether checking hasattr is better than just trying to read the object and catching an error

Agree, that's fine. An AttributeError in this calling function might look weird, though, so you could have both.

you could read it into BytesIO and pass the BytesIO instance

This is in general a bad idea, since we are wanting to deal with large files, and we have random access capabilities.

Ideally xarray would work with fsspec

It does, but this is an edge case of using fsspec for local files; these are normally passed as the filename.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   requires io.IOBase subclass rather than duck file-like 839823306
808605422 https://github.com/pydata/xarray/issues/5070#issuecomment-808605422 https://api.github.com/repos/pydata/xarray/issues/5070 MDEyOklzc3VlQ29tbWVudDgwODYwNTQyMg== NowanIlfideme 2067093 2021-03-27T00:39:26Z 2021-03-27T00:43:35Z NONE

Just ran into this. Unsure whether checking hasattr is better than just trying to read the object and catching an error - someone could implement a non-compliant read method, which would create other errors.

As a workaround, you could read it into BytesIO and pass the BytesIO instance:

```python import fsspec import xarray as xr from io import BytesIO

of = fsspec.open("example.nc") with of as f: xr.load_dataset(BytesIO(f.read())) ```

Also, here's the link to the code referenced above.

Ideally xarray would work with fsspec or pyfilesystem2 out of the box (to parse access URLs, for example). I've had to fall back to using BytesIO buffers too many times. 😛

Edit: You don't even need BytesIO, it works even with Bytes:

```python import fsspec import xarray as xr

of = fsspec.open("example.nc") with of as f: xr.load_dataset(f.read()) ```

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   requires io.IOBase subclass rather than duck file-like 839823306
805900745 https://github.com/pydata/xarray/issues/5070#issuecomment-805900745 https://api.github.com/repos/pydata/xarray/issues/5070 MDEyOklzc3VlQ29tbWVudDgwNTkwMDc0NQ== martindurant 6042212 2021-03-24T15:07:16Z 2021-03-24T15:07:16Z CONTRIBUTOR 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   requires io.IOBase subclass rather than duck file-like 839823306

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);