home / github

Menu
  • GraphQL API
  • Search all tables

issue_comments

Table actions
  • GraphQL API for issue_comments

3 rows where issue = 828805728 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 3

  • benbovy 1
  • jsignell 1
  • darikg 1

author_association 2

  • CONTRIBUTOR 2
  • MEMBER 1

issue 1

  • Extracting `formatting_html` as a standalone library? · 3 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
797099807 https://github.com/pydata/xarray/issues/5022#issuecomment-797099807 https://api.github.com/repos/pydata/xarray/issues/5022 MDEyOklzc3VlQ29tbWVudDc5NzA5OTgwNw== darikg 6875882 2021-03-11T22:45:13Z 2021-03-11T22:45:13Z CONTRIBUTOR

Thank you both! I'll report back if I get anywhere with it

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  Extracting `formatting_html` as a standalone library? 828805728
796789957 https://github.com/pydata/xarray/issues/5022#issuecomment-796789957 https://api.github.com/repos/pydata/xarray/issues/5022 MDEyOklzc3VlQ29tbWVudDc5Njc4OTk1Nw== benbovy 4160723 2021-03-11T14:47:51Z 2021-03-11T14:47:51Z MEMBER

I'm glad too that you like it. Without the work of @jsignell this would likely still be an open, unfinished PR!

Not sure either how we could generalize it. Also, note that the CSS code used for displaying this rich output is not super robust: it relies on some dirty hacks that required special care in some front-ends (e.g., https://github.com/pydata/pydata-sphinx-theme/issues/274). It's still not displayed correctly when notebooks are rendered on GitHub (although in general GitHub's notebook rendering is not quite reliable anyway).

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  Extracting `formatting_html` as a standalone library? 828805728
796749794 https://github.com/pydata/xarray/issues/5022#issuecomment-796749794 https://api.github.com/repos/pydata/xarray/issues/5022 MDEyOklzc3VlQ29tbWVudDc5Njc0OTc5NA== jsignell 4806877 2021-03-11T13:51:37Z 2021-03-11T13:51:37Z CONTRIBUTOR

I'm glad you like it! @benbovy really did all the work on writing it. I think there was some talk of extracting it to a separate library, but I'm not sure if it was obvious how to generalize it. It depends whether you would want it to be a standalone library (like pprint) or whether you'd want the libraries to integrate with it (probably using entrypoints).

I would start by thinking about one or two other classes that you'd like to see represented this way and try to see how well what currently exists generalizes.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  Extracting `formatting_html` as a standalone library? 828805728

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options:

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);
Powered by Datasette · Queries took 12.05ms · About: xarray-datasette