issue_comments

Table actions

6 rows where issue = 828352998 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

author_association 3

issue 1

  • GH5005 fix documentation on open_rasterio · 6 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
799533136 https://github.com/pydata/xarray/pull/5021#issuecomment-799533136 https://api.github.com/repos/pydata/xarray/issues/5021 MDEyOklzc3VlQ29tbWVudDc5OTUzMzEzNg== keewis 14808389 2021-03-15T15:56:17Z 2021-03-15T15:56:17Z MEMBER

thanks for the update, @gabriel-abrahao. I noticed this is you first PR here. Welcome to xarray!

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   GH5005 fix documentation on open_rasterio 828352998
799056917 https://github.com/pydata/xarray/pull/5021#issuecomment-799056917 https://api.github.com/repos/pydata/xarray/issues/5021 MDEyOklzc3VlQ29tbWVudDc5OTA1NjkxNw== pep8speaks 24736507 2021-03-15T03:02:20Z 2021-03-15T13:46:59Z NONE

Hello @gabriel-abrahao! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! :beers:

Comment last updated at 2021-03-15 13:46:59 UTC
 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   GH5005 fix documentation on open_rasterio 828352998
799064102 https://github.com/pydata/xarray/pull/5021#issuecomment-799064102 https://api.github.com/repos/pydata/xarray/issues/5021 MDEyOklzc3VlQ29tbWVudDc5OTA2NDEwMg== gabriel-abrahao 30908904 2021-03-15T03:27:14Z 2021-03-15T03:27:14Z CONTRIBUTOR

you could also use the CI to verify the changes (the doctests CI is pretty fast), but as I said we can leave that to a new PR.

Unless someone else has any comments I'll merge this tomorrow.

Just did that, thanks! Is there a way to make the CI run just the check I want it to?

I'm not sure if every doctest has to import xarray as xr and import numpy as np, so I added those just in case and it's passing.

Also, right multiplying matrices will be deprecated in numpy, so now transform is on the left side.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   GH5005 fix documentation on open_rasterio 828352998
799043522 https://github.com/pydata/xarray/pull/5021#issuecomment-799043522 https://api.github.com/repos/pydata/xarray/issues/5021 MDEyOklzc3VlQ29tbWVudDc5OTA0MzUyMg== keewis 14808389 2021-03-15T02:13:45Z 2021-03-15T02:13:45Z MEMBER

you could also use the CI to verify the changes (the doctests CI is pretty fast), but as I said we can leave that to a new PR.

Unless someone else has any comments I'll merge this tomorrow.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   GH5005 fix documentation on open_rasterio 828352998
799040308 https://github.com/pydata/xarray/pull/5021#issuecomment-799040308 https://api.github.com/repos/pydata/xarray/issues/5021 MDEyOklzc3VlQ29tbWVudDc5OTA0MDMwOA== gabriel-abrahao 30908904 2021-03-15T02:03:37Z 2021-03-15T02:03:37Z CONTRIBUTOR

@gabriel-abrahao, do you want to try converting the code block to doctest? Otherwise this looks good to me and should be ready for merging.

I tried, but building the documentation is failing on both my Linux computers just like in #4257 , so unfortunately I can't make it. 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   GH5005 fix documentation on open_rasterio 828352998
798984437 https://github.com/pydata/xarray/pull/5021#issuecomment-798984437 https://api.github.com/repos/pydata/xarray/issues/5021 MDEyOklzc3VlQ29tbWVudDc5ODk4NDQzNw== keewis 14808389 2021-03-14T21:37:08Z 2021-03-14T21:37:08Z MEMBER

@gabriel-abrahao, do you want to try converting the code block to doctest? Otherwise this looks good to me and should be ready for merging.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   GH5005 fix documentation on open_rasterio 828352998

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);