issue_comments

Table actions

9 rows where issue = 827233565 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

author_association 2

issue 1

  • Handle empty containers in zarr chunk checks · 9 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
867798517 https://github.com/pydata/xarray/pull/5019#issuecomment-867798517 https://api.github.com/repos/pydata/xarray/issues/5019 MDEyOklzc3VlQ29tbWVudDg2Nzc5ODUxNw== chrisroat 1053153 2021-06-24T16:52:29Z 2021-06-24T16:52:29Z CONTRIBUTOR

Sure thing. I'll revive it.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Handle empty containers in zarr chunk checks 827233565
867052541 https://github.com/pydata/xarray/pull/5019#issuecomment-867052541 https://api.github.com/repos/pydata/xarray/issues/5019 MDEyOklzc3VlQ29tbWVudDg2NzA1MjU0MQ== jhamman 2443309 2021-06-23T18:10:43Z 2021-06-23T18:10:43Z MEMBER

@chrisroat - apologies for letting this sit for so long without a review. If you are interested in finishing it up, we may need to open a new PR to account for the closure here. If so, please ping me directly and I'll get on the review asap.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Handle empty containers in zarr chunk checks 827233565
867026580 https://github.com/pydata/xarray/pull/5019#issuecomment-867026580 https://api.github.com/repos/pydata/xarray/issues/5019 MDEyOklzc3VlQ29tbWVudDg2NzAyNjU4MA== keewis 14808389 2021-06-23T17:30:45Z 2021-06-23T17:31:00Z MEMBER

the originating repository for this PR has been deleted, though, so we might have trouble to reopen

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Handle empty containers in zarr chunk checks 827233565
867025951 https://github.com/pydata/xarray/pull/5019#issuecomment-867025951 https://api.github.com/repos/pydata/xarray/issues/5019 MDEyOklzc3VlQ29tbWVudDg2NzAyNTk1MQ== keewis 14808389 2021-06-23T17:29:45Z 2021-06-23T17:29:45Z MEMBER

yes, that was indeed unintentional. I didn't intentionally close anything today so every PR that was closed should be reopened (somehow)

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Handle empty containers in zarr chunk checks 827233565
867024800 https://github.com/pydata/xarray/pull/5019#issuecomment-867024800 https://api.github.com/repos/pydata/xarray/issues/5019 MDEyOklzc3VlQ29tbWVudDg2NzAyNDgwMA== jhamman 2443309 2021-06-23T17:27:55Z 2021-06-23T17:27:55Z MEMBER

@keewis - did we mean to close this or was this related to the switch to main (#5516)?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Handle empty containers in zarr chunk checks 827233565
841036684 https://github.com/pydata/xarray/pull/5019#issuecomment-841036684 https://api.github.com/repos/pydata/xarray/issues/5019 MDEyOklzc3VlQ29tbWVudDg0MTAzNjY4NA== max-sixty 5635139 2021-05-14T06:19:25Z 2021-05-14T06:19:25Z MEMBER

@chrisroat sorry this fell through the cracks; we're working on making out process more robust.

@pydata/xarray any thoughts?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Handle empty containers in zarr chunk checks 827233565
840975200 https://github.com/pydata/xarray/pull/5019#issuecomment-840975200 https://api.github.com/repos/pydata/xarray/issues/5019 MDEyOklzc3VlQ29tbWVudDg0MDk3NTIwMA== chrisroat 1053153 2021-05-14T03:08:02Z 2021-05-14T03:08:02Z CONTRIBUTOR

Is this solution desired, or is there a deeper fix?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Handle empty containers in zarr chunk checks 827233565
795014523 https://github.com/pydata/xarray/pull/5019#issuecomment-795014523 https://api.github.com/repos/pydata/xarray/issues/5019 MDEyOklzc3VlQ29tbWVudDc5NTAxNDUyMw== chrisroat 1053153 2021-03-10T07:24:58Z 2021-03-10T07:24:58Z CONTRIBUTOR

I do not see the failures in my client that are seen in the checks, so there must be some mismatch in the environments.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Handle empty containers in zarr chunk checks 827233565
794986294 https://github.com/pydata/xarray/pull/5019#issuecomment-794986294 https://api.github.com/repos/pydata/xarray/issues/5019 MDEyOklzc3VlQ29tbWVudDc5NDk4NjI5NA== chrisroat 1053153 2021-03-10T06:56:36Z 2021-03-10T07:01:08Z CONTRIBUTOR

In putting this together, I noted that open_zarr to re-read the data triggers this bug, while open_dataset(..., engine='zarr') does not. I'm not sure if my proposed fix is a band-aid, or if something in open_zarr is the real culprit.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Handle empty containers in zarr chunk checks 827233565

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);