issue_comments

Table actions

4 rows where issue = 818051289 and user = 14808389 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date)

user 1

  • keewis · 4 ✖

issue 1

  • add a combine_attrs option to open_mfdataset · 4 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
812868358 https://github.com/pydata/xarray/pull/4971#issuecomment-812868358 https://api.github.com/repos/pydata/xarray/issues/4971 MDEyOklzc3VlQ29tbWVudDgxMjg2ODM1OA== keewis 14808389 2021-04-03T13:52:26Z 2021-04-03T13:52:26Z MEMBER

should we merge this? It is blocking #4902, which in turn is blocking #5041.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   add a combine_attrs option to open_mfdataset 818051289
811436416 https://github.com/pydata/xarray/pull/4971#issuecomment-811436416 https://api.github.com/repos/pydata/xarray/issues/4971 MDEyOklzc3VlQ29tbWVudDgxMTQzNjQxNg== keewis 14808389 2021-03-31T20:22:04Z 2021-03-31T20:22:04Z MEMBER

(the RTD build fails because docs.scipy.org is down)

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   add a combine_attrs option to open_mfdataset 818051289
811386980 https://github.com/pydata/xarray/pull/4971#issuecomment-811386980 https://api.github.com/repos/pydata/xarray/issues/4971 MDEyOklzc3VlQ29tbWVudDgxMTM4Njk4MA== keewis 14808389 2021-03-31T19:39:17Z 2021-03-31T19:39:17Z MEMBER

I decided to change the default from "drop" to "override", so the only thing that changes is that the attrs for variables will not be dropped but kept according to combine_attrs.

I guess that means that unless the CI fails this should be ready for review / merging?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   add a combine_attrs option to open_mfdataset 818051289
787521182 https://github.com/pydata/xarray/pull/4971#issuecomment-787521182 https://api.github.com/repos/pydata/xarray/issues/4971 MDEyOklzc3VlQ29tbWVudDc4NzUyMTE4Mg== keewis 14808389 2021-02-28T20:53:23Z 2021-02-28T20:53:23Z MEMBER

for the main object, yes, but for the variables of that object "drop" is currently always used. That means that if we try to sync both we introduce a breaking change.

We might eventually want to switch both to "drop_conflicts" so we would need to go through a deprecation cycle anyways.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   add a combine_attrs option to open_mfdataset 818051289

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);