issue_comments

Table actions

5 rows where issue = 814813503 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 2

issue 1

  • Upstream CI: limit runtime · 5 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
784517985 https://github.com/pydata/xarray/pull/4946#issuecomment-784517985 https://api.github.com/repos/pydata/xarray/issues/4946 MDEyOklzc3VlQ29tbWVudDc4NDUxNzk4NQ== keewis 14808389 2021-02-23T21:15:51Z 2021-02-24T14:37:04Z MEMBER

The test status becomes ERROR, so the parsing script will not collect those. To fix that, could you also change https://github.com/pydata/xarray/blob/0f65307d6bd611767863edc50a2a755b9bb819ff/.github/workflows/parse_logs.py#L21 to python lambda l: l.startswith("FAILED") or l.startswith("ERROR"), up_to_section_content

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Upstream CI: limit runtime 814813503
784893499 https://github.com/pydata/xarray/pull/4946#issuecomment-784893499 https://api.github.com/repos/pydata/xarray/issues/4946 MDEyOklzc3VlQ29tbWVudDc4NDg5MzQ5OQ== mathause 10194086 2021-02-24T08:15:01Z 2021-02-24T08:15:01Z MEMBER

Thanks for the reviews @keewis

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Upstream CI: limit runtime 814813503
784563352 https://github.com/pydata/xarray/pull/4946#issuecomment-784563352 https://api.github.com/repos/pydata/xarray/issues/4946 MDEyOklzc3VlQ29tbWVudDc4NDU2MzM1Mg== mathause 10194086 2021-02-23T22:36:59Z 2021-02-23T22:36:59Z MEMBER

The timeout seems to work. If there are too many tests that take long the solution might not help but for the current problem it seems to be fine. I am merging so we catch the Upstream dev run in 1.5 h to see if the test now fails successfully ;-)

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Upstream CI: limit runtime 814813503
784512412 https://github.com/pydata/xarray/pull/4946#issuecomment-784512412 https://api.github.com/repos/pydata/xarray/issues/4946 MDEyOklzc3VlQ29tbWVudDc4NDUxMjQxMg== keewis 14808389 2021-02-23T21:05:49Z 2021-02-23T21:05:49Z MEMBER

I seem to have misunderstood the purpose of --timeout: as far as I can tell, if a single test takes more than the value passed to it, a Failed instance is raised. As we don't have tests that should run more than 30s (I think?), we can safely set it to 2min.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Upstream CI: limit runtime 814813503
784498569 https://github.com/pydata/xarray/pull/4946#issuecomment-784498569 https://api.github.com/repos/pydata/xarray/issues/4946 MDEyOklzc3VlQ29tbWVudDc4NDQ5ODU2OQ== keewis 14808389 2021-02-23T20:43:55Z 2021-02-23T20:43:55Z MEMBER

you can probably limit that to 1.5h or 2h: our CI currently takes about 30 minutes to run so if it suddenly takes more than double there is something wrong, anyway

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Upstream CI: limit runtime 814813503

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);