issue_comments

Table actions

5 rows where issue = 813246980 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

author_association 3

issue 1

  • Use definition of DTypeLike from Numpy if found · 5 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
784453434 https://github.com/pydata/xarray/pull/4941#issuecomment-784453434 https://api.github.com/repos/pydata/xarray/issues/4941 MDEyOklzc3VlQ29tbWVudDc4NDQ1MzQzNA== jenshnielsen 548266 2021-02-23T19:28:19Z 2021-02-23T19:28:19Z CONTRIBUTOR

Thanks @max-sixty @mathause 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Use definition of DTypeLike from Numpy if found 813246980
784449036 https://github.com/pydata/xarray/pull/4941#issuecomment-784449036 https://api.github.com/repos/pydata/xarray/issues/4941 MDEyOklzc3VlQ29tbWVudDc4NDQ0OTAzNg== max-sixty 5635139 2021-02-23T19:20:51Z 2021-02-23T19:20:51Z MEMBER

Great, merging. Thanks @jenshnielsen !

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Use definition of DTypeLike from Numpy if found 813246980
784446439 https://github.com/pydata/xarray/pull/4941#issuecomment-784446439 https://api.github.com/repos/pydata/xarray/issues/4941 MDEyOklzc3VlQ29tbWVudDc4NDQ0NjQzOQ== mathause 10194086 2021-02-23T19:16:44Z 2021-02-23T19:16:44Z MEMBER

Thanks. Looks good. IMHO typing is a nice-to-have far-from-complete part of xarray & I wouldn't bother about backwards compatibility (of the typing). Up to you.

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Use definition of DTypeLike from Numpy if found 813246980
783987344 https://github.com/pydata/xarray/pull/4941#issuecomment-783987344 https://api.github.com/repos/pydata/xarray/issues/4941 MDEyOklzc3VlQ29tbWVudDc4Mzk4NzM0NA== jenshnielsen 548266 2021-02-23T07:59:46Z 2021-02-23T09:29:14Z CONTRIBUTOR

@max-sixty Thanks :)

IIUC the existing code may break type-checking, but the code will still run on numpy<1.20; please let me know if that's not the case.

Yes the existing code which is now the fallback could be considered wrong as it does not match the definitions that numpy ships. We could consider syncing that with numpy but that seems like more trouble than its worth since no one is likely to typecheck this against the definitions of numpy functions without running numpy 1.20 or newer.

The numpy definition is:

DTypeLike = Union[ np.dtype, # default data type (float64) None, # array-scalar types and generic types type, # TODO: enumerate these when we add type hints for numpy scalars # anything with a dtype attribute "_SupportsDType[np.dtype[Any]]", # character codes, type strings or comma-separated fields, e.g., 'float64' str, _VoidDTypeLike, ]

So one could add None and type but should probably omit the rest in order to not replicate too much of numpys internal type definitions

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Use definition of DTypeLike from Numpy if found 813246980
783177227 https://github.com/pydata/xarray/pull/4941#issuecomment-783177227 https://api.github.com/repos/pydata/xarray/issues/4941 MDEyOklzc3VlQ29tbWVudDc4MzE3NzIyNw== pep8speaks 24736507 2021-02-22T08:06:42Z 2021-02-22T08:09:20Z NONE

Hello @jenshnielsen! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! :beers:

Comment last updated at 2021-02-22 08:09:19 UTC
 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Use definition of DTypeLike from Numpy if found 813246980

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);