issue_comments

Table actions

5 rows where issue = 807620560 and user = 14808389 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

These facets timed out: author_association, issue

user 1

  • keewis · 5 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
832817634 https://github.com/pydata/xarray/pull/4902#issuecomment-832817634 https://api.github.com/repos/pydata/xarray/issues/4902 MDEyOklzc3VlQ29tbWVudDgzMjgxNzYzNA== keewis 14808389 2021-05-05T16:07:02Z 2021-05-05T16:07:02Z MEMBER

once CI passes this should be ready for merging.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   also apply combine_attrs to the attrs of the variables 807620560
830684715 https://github.com/pydata/xarray/pull/4902#issuecomment-830684715 https://api.github.com/repos/pydata/xarray/issues/4902 MDEyOklzc3VlQ29tbWVudDgzMDY4NDcxNQ== keewis 14808389 2021-05-01T19:47:49Z 2021-05-01T19:48:35Z MEMBER

once the backwards compatibility issue has been resolved this should be ready for merging

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   also apply combine_attrs to the attrs of the variables 807620560
813295971 https://github.com/pydata/xarray/pull/4902#issuecomment-813295971 https://api.github.com/repos/pydata/xarray/issues/4902 MDEyOklzc3VlQ29tbWVudDgxMzI5NTk3MQ== keewis 14808389 2021-04-05T09:17:58Z 2021-04-05T09:18:23Z MEMBER

I've got a few small questions left (see the comments), but otherwise this should be ready for reviewing

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   also apply combine_attrs to the attrs of the variables 807620560
780884727 https://github.com/pydata/xarray/pull/4902#issuecomment-780884727 https://api.github.com/repos/pydata/xarray/issues/4902 MDEyOklzc3VlQ29tbWVudDc4MDg4NDcyNw== keewis 14808389 2021-02-17T22:04:12Z 2021-02-17T22:04:12Z MEMBER

I just noticed this would do the same as #4017, which suggests merging attrs in merge.unique_variables. Would that be the correct place to fix this?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   also apply combine_attrs to the attrs of the variables 807620560
778536907 https://github.com/pydata/xarray/pull/4902#issuecomment-778536907 https://api.github.com/repos/pydata/xarray/issues/4902 MDEyOklzc3VlQ29tbWVudDc3ODUzNjkwNw== keewis 14808389 2021-02-13T01:13:10Z 2021-02-13T01:13:10Z MEMBER

I tried to fix the tests but the remaining failures in test_backends (open_mfdataset) are due to the expectation that combine_attrs="drop" only drops attrs on the main object.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   also apply combine_attrs to the attrs of the variables 807620560

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);