issue_comments

Table actions

14 rows where issue = 806436724 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

author_association 2

issue 1

  • release 0.17.0 · 14 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
786871459 https://github.com/pydata/xarray/issues/4894#issuecomment-786871459 https://api.github.com/repos/pydata/xarray/issues/4894 MDEyOklzc3VlQ29tbWVudDc4Njg3MTQ1OQ== dcherian 2448579 2021-02-26T20:16:11Z 2021-02-26T20:16:11Z MEMBER

Thanks @max-sixty !

 
{
    "total_count": 2,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 1,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   release 0.17.0 806436724
782931137 https://github.com/pydata/xarray/issues/4894#issuecomment-782931137 https://api.github.com/repos/pydata/xarray/issues/4894 MDEyOklzc3VlQ29tbWVudDc4MjkzMTEzNw== mathause 10194086 2021-02-21T21:37:20Z 2021-02-21T21:37:20Z MEMBER

Yes that's the one - thanks! 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   release 0.17.0 806436724
782929644 https://github.com/pydata/xarray/issues/4894#issuecomment-782929644 https://api.github.com/repos/pydata/xarray/issues/4894 MDEyOklzc3VlQ29tbWVudDc4MjkyOTY0NA== keewis 14808389 2021-02-21T21:26:35Z 2021-02-21T21:26:35Z MEMBER

There is a small mis-formatting in "whats-new"

if you're talking about the versions table: this should be fixed in #4907

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   release 0.17.0 806436724
782327590 https://github.com/pydata/xarray/issues/4894#issuecomment-782327590 https://api.github.com/repos/pydata/xarray/issues/4894 MDEyOklzc3VlQ29tbWVudDc4MjMyNzU5MA== mathause 10194086 2021-02-19T20:34:16Z 2021-02-19T20:34:16Z MEMBER

There is a small mis-formatting in "whats-new", that would be good to fix: http://xarray.pydata.org/en/latest/whats-new.html

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   release 0.17.0 806436724
780953464 https://github.com/pydata/xarray/issues/4894#issuecomment-780953464 https://api.github.com/repos/pydata/xarray/issues/4894 MDEyOklzc3VlQ29tbWVudDc4MDk1MzQ2NA== slevang 39069044 2021-02-18T00:51:04Z 2021-02-18T00:51:04Z CONTRIBUTOR

4849 should be almost ready to go. Would be good for someone else to confirm the API makes sense. Additional features and performance enhancements could be added in later releases as long as the API is acceptable.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   release 0.17.0 806436724
780735665 https://github.com/pydata/xarray/issues/4894#issuecomment-780735665 https://api.github.com/repos/pydata/xarray/issues/4894 MDEyOklzc3VlQ29tbWVudDc4MDczNTY2NQ== kmuehlbauer 5821660 2021-02-17T17:53:29Z 2021-02-17T17:53:29Z MEMBER

I don't think we will be ready by this week-end and we don't want to rush the switch to the new API without some thorough testing by others. We will wait for the next release.

No worries, @alexamici, as the API can be switched to v2 already, this is no major problem. Better safe than sorry wrt testing. Thank you and your colleagues! 

{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   release 0.17.0 806436724
780731411 https://github.com/pydata/xarray/issues/4894#issuecomment-780731411 https://api.github.com/repos/pydata/xarray/issues/4894 MDEyOklzc3VlQ29tbWVudDc4MDczMTQxMQ== alexamici 226037 2021-02-17T17:46:46Z 2021-02-17T17:46:46Z MEMBER

I don't think we will be ready by this week-end and we don't want to rush the switch to the new API without some thorough testing by others. We will wait for the next release.

 
{
    "total_count": 2,
    "+1": 2,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   release 0.17.0 806436724
780699009 https://github.com/pydata/xarray/issues/4894#issuecomment-780699009 https://api.github.com/repos/pydata/xarray/issues/4894 MDEyOklzc3VlQ29tbWVudDc4MDY5OTAwOQ== kmuehlbauer 5821660 2021-02-17T16:57:37Z 2021-02-17T16:57:57Z MEMBER

@alexamici can you get the PR in by then?

This would be really great. But if it doesn't fit now, I hope a release will be cut right after finalising backend refactor. This is an eagerly awaited addition. 

{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   release 0.17.0 806436724
780692008 https://github.com/pydata/xarray/issues/4894#issuecomment-780692008 https://api.github.com/repos/pydata/xarray/issues/4894 MDEyOklzc3VlQ29tbWVudDc4MDY5MjAwOA== dcherian 2448579 2021-02-17T16:47:28Z 2021-02-17T16:47:28Z MEMBER

@max-sixty will cut a release this weekend. @alexamici can you get the PR in by then? If not, we can release again! and again! 

{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   release 0.17.0 806436724
778774317 https://github.com/pydata/xarray/issues/4894#issuecomment-778774317 https://api.github.com/repos/pydata/xarray/issues/4894 MDEyOklzc3VlQ29tbWVudDc3ODc3NDMxNw== Illviljan 14371165 2021-02-14T12:57:27Z 2021-02-14T13:04:23Z MEMBER

May I suggest #4740 as well. I think it's ready and it helps me quite a bit in my 2k+ data variable use cases.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   release 0.17.0 806436724
778447800 https://github.com/pydata/xarray/issues/4894#issuecomment-778447800 https://api.github.com/repos/pydata/xarray/issues/4894 MDEyOklzc3VlQ29tbWVudDc3ODQ0NzgwMA== max-sixty 5635139 2021-02-12T20:50:52Z 2021-02-12T20:50:52Z MEMBER

Unless we're really confident that a feature is a few days away, I'd vote to generally proceed with releases. Releases are fairly cheap to do now (and I'm happy to do them), and uncoupling parts of the process lets it move faster.

Ofc if we have regressions, then we should solve those. (I have been under a crunch recently but can hopefully help more in a week or so)

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   release 0.17.0 806436724
778230463 https://github.com/pydata/xarray/issues/4894#issuecomment-778230463 https://api.github.com/repos/pydata/xarray/issues/4894 MDEyOklzc3VlQ29tbWVudDc3ODIzMDQ2Mw== dcherian 2448579 2021-02-12T14:33:01Z 2021-02-12T14:33:17Z MEMBER

@alexamici no target date AFAIK. it'd be nice to release soon since there are incompatibilities with a few new library versions

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   release 0.17.0 806436724
778060647 https://github.com/pydata/xarray/issues/4894#issuecomment-778060647 https://api.github.com/repos/pydata/xarray/issues/4894 MDEyOklzc3VlQ29tbWVudDc3ODA2MDY0Nw== alexamici 226037 2021-02-12T08:44:55Z 2021-02-12T08:45:23Z MEMBER

The new flexible backend API is almost ready #4309 (see PRs with label CZI Grant) and the plan is for it to become the default backend API for the next major release (cc @shoyer @jhamman)

I'll prepare the PR to move the code in apiv2.py to api.py soon.

@dcherian do you have a target release date?

 
{
    "total_count": 2,
    "+1": 2,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   release 0.17.0 806436724
777503859 https://github.com/pydata/xarray/issues/4894#issuecomment-777503859 https://api.github.com/repos/pydata/xarray/issues/4894 MDEyOklzc3VlQ29tbWVudDc3NzUwMzg1OQ== spencerkclark 6628425 2021-02-11T14:34:11Z 2021-02-11T14:34:11Z MEMBER

Thanks @dcherian! I agree those would be good to get in too.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   release 0.17.0 806436724

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);