issue_comments

Table actions

4 rows where issue = 802400938 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

user 3

author_association 2

issue 1

  • fix da.pad example for numpy 1.20 · 4 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
774669534 https://github.com/pydata/xarray/pull/4865#issuecomment-774669534 https://api.github.com/repos/pydata/xarray/issues/4865 MDEyOklzc3VlQ29tbWVudDc3NDY2OTUzNA== mathause 10194086 2021-02-07T12:52:57Z 2021-02-07T12:52:57Z MEMBER

Thanks for the review. I added some minimal tests. I think it could be good to discuss the type coercion in a new issue.

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   fix da.pad example for numpy 1.20 802400938
774548429 https://github.com/pydata/xarray/pull/4865#issuecomment-774548429 https://api.github.com/repos/pydata/xarray/issues/4865 MDEyOklzc3VlQ29tbWVudDc3NDU0ODQyOQ== keewis 14808389 2021-02-06T21:44:49Z 2021-02-06T21:48:36Z MEMBER

not sure. I would probably try to either check the new behavior of numpy with an example, or just copy the doctest into a test.

Edit: it would probably be good to merge this as soon as possible, all PRs fail because of this.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   fix da.pad example for numpy 1.20 802400938
774494996 https://github.com/pydata/xarray/pull/4865#issuecomment-774494996 https://api.github.com/repos/pydata/xarray/issues/4865 MDEyOklzc3VlQ29tbWVudDc3NDQ5NDk5Ng== mark-boer 12862013 2021-02-06T15:34:24Z 2021-02-06T15:34:24Z CONTRIBUTOR

@keewis, I agree a test would be nice, but what kind of test would you want to add? I mean, xarray just mimics the behaviour of np.pad and dask.array.pad. And the default behaviour of numpy was a bit funky, which is probably why they changed it.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   fix da.pad example for numpy 1.20 802400938
774269657 https://github.com/pydata/xarray/pull/4865#issuecomment-774269657 https://api.github.com/repos/pydata/xarray/issues/4865 MDEyOklzc3VlQ29tbWVudDc3NDI2OTY1Nw== mathause 10194086 2021-02-05T20:26:23Z 2021-02-05T20:26:23Z MEMBER

cc @mark-boer

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   fix da.pad example for numpy 1.20 802400938

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);