issue_comments

Table actions

5 rows where issue = 791277757 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 4

issue 1

  • expose _to_temp_dataset / _from_temp_dataset as semi-public API? · 5 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
765064046 https://github.com/pydata/xarray/issues/4837#issuecomment-765064046 https://api.github.com/repos/pydata/xarray/issues/4837 MDEyOklzc3VlQ29tbWVudDc2NTA2NDA0Ng== shoyer 1217238 2021-01-22T02:07:07Z 2021-01-22T02:07:07Z MEMBER

Related: There's some weirdness about _to_temp_dataset not preserving name.

It used to preserve name, but now name is always set to the _THIS_ARRAY object. This is for two reasons:

  1. It isn't always possible to convert a DataArray into a Dataset preserving name, if name is also found on a coordinate.
  2. To ensure that xarray functions always work, even in this case, it was more reliable to always replace the name. If we only replaced name in case (1), then it's likely that some functions wouldn't handle names of that form and would produce an error only in that case.

To the extent the goal is "apply a function that takes a dataset to this dataarray", we could make a function that does exactly that and use _to_temp_dataset within that. Does that make sense?

This sounds like a fine idea to me. It's kind of the opposite of Dataset.map.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   expose _to_temp_dataset / _from_temp_dataset as semi-public API? 791277757
764836626 https://github.com/pydata/xarray/issues/4837#issuecomment-764836626 https://api.github.com/repos/pydata/xarray/issues/4837 MDEyOklzc3VlQ29tbWVudDc2NDgzNjYyNg== keewis 14808389 2021-01-21T18:07:37Z 2021-01-21T18:07:37Z MEMBER

To the extent the goal is "apply a function that takes a dataset to this dataarray", we could make a function that does exactly that and use _to_temp_dataset within that.

yes, I think that would work, too.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   expose _to_temp_dataset / _from_temp_dataset as semi-public API? 791277757
764802078 https://github.com/pydata/xarray/issues/4837#issuecomment-764802078 https://api.github.com/repos/pydata/xarray/issues/4837 MDEyOklzc3VlQ29tbWVudDc2NDgwMjA3OA== max-sixty 5635139 2021-01-21T17:13:19Z 2021-01-21T17:13:19Z MEMBER

That seems very reasonable.

To the extent the goal is "apply a function that takes a dataset to this dataarray", we could make a function that does exactly that and use _to_temp_dataset within that. Does that make sense?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   expose _to_temp_dataset / _from_temp_dataset as semi-public API? 791277757
764778210 https://github.com/pydata/xarray/issues/4837#issuecomment-764778210 https://api.github.com/repos/pydata/xarray/issues/4837 MDEyOklzc3VlQ29tbWVudDc2NDc3ODIxMA== keewis 14808389 2021-01-21T16:39:54Z 2021-01-21T16:39:54Z MEMBER

that's true. I guess for that there's the name parameter to _from_temp_dataset, which of course can't be used if _to_temp_dataset and _from_temp_dataset are called in different functions.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   expose _to_temp_dataset / _from_temp_dataset as semi-public API? 791277757
764770434 https://github.com/pydata/xarray/issues/4837#issuecomment-764770434 https://api.github.com/repos/pydata/xarray/issues/4837 MDEyOklzc3VlQ29tbWVudDc2NDc3MDQzNA== dcherian 2448579 2021-01-21T16:29:56Z 2021-01-21T16:29:56Z MEMBER

Related: There's some weirdness about _to_temp_dataset not preserving name. I had to work around that for map_blocks

https://github.com/pydata/xarray/blob/bc35548d96caaec225be9a26afbbaa94069c9494/xarray/core/parallel.py#L74-L94

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   expose _to_temp_dataset / _from_temp_dataset as semi-public API? 791277757

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);