issue_comments

Table actions

6 rows where issue = 790677360 and user = 14808389 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

user 1

  • keewis · 6 ✖

issue 1

  • 📚 New theme & rearrangement of the docs · 6 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
792258804 https://github.com/pydata/xarray/pull/4835#issuecomment-792258804 https://api.github.com/repos/pydata/xarray/issues/4835 MDEyOklzc3VlQ29tbWVudDc5MjI1ODgwNA== keewis 14808389 2021-03-07T11:06:34Z 2021-03-07T11:06:34Z MEMBER

I will see if there's a remedy for this.

You could try to reduce the (quite big) margin on the left / right

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   📚 New theme & rearrangement of the docs 790677360
792099308 https://github.com/pydata/xarray/pull/4835#issuecomment-792099308 https://api.github.com/repos/pydata/xarray/issues/4835 MDEyOklzc3VlQ29tbWVudDc5MjA5OTMwOA== keewis 14808389 2021-03-06T22:55:53Z 2021-03-06T22:55:53Z MEMBER

@andersy005, the copy button feature is a great find, copying examples is so much easier than before.

The only issue I have with the new theme is that due to the maximum line length we use some examples have horizontal scroll bars (unless the left side bar is hidden).

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   📚 New theme & rearrangement of the docs 790677360
789903854 https://github.com/pydata/xarray/pull/4835#issuecomment-789903854 https://api.github.com/repos/pydata/xarray/issues/4835 MDEyOklzc3VlQ29tbWVudDc4OTkwMzg1NA== keewis 14808389 2021-03-03T17:20:32Z 2021-03-03T17:20:32Z MEMBER

unrelated to that: the internals page is a collection of mostly unrelated topics. It might be good to break it up into separate pages (e.g. "Variable", "duckarray integration", "accessors", "zarr spec", "custom backends", etc.)

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   📚 New theme & rearrangement of the docs 790677360
789900682 https://github.com/pydata/xarray/pull/4835#issuecomment-789900682 https://api.github.com/repos/pydata/xarray/issues/4835 MDEyOklzc3VlQ29tbWVudDc4OTkwMDY4Mg== keewis 14808389 2021-03-03T17:16:04Z 2021-03-03T17:16:04Z MEMBER

I don't know any, unfortunately. We do want to keep the warnings-as-errors because those tend to result in broken page layouts, but RTD insists on the parallel build (which does make the builds faster) and myst-nb doesn't seem to support it. Is there a particular reason why we're moving away from nbsphinx?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   📚 New theme & rearrangement of the docs 790677360
772831895 https://github.com/pydata/xarray/pull/4835#issuecomment-772831895 https://api.github.com/repos/pydata/xarray/issues/4835 MDEyOklzc3VlQ29tbWVudDc3MjgzMTg5NQ== keewis 14808389 2021-02-03T21:20:40Z 2021-02-03T21:21:13Z MEMBER

the build step also has a -W flag which turns warnings into Errors and causes a non 0 exit status

this is intentional: these errors usually cause the page layout to break somehow, so failing the sphinx build (especially in PRs) is important. We also try to minimize the nitpicky errors, but we don't enforce that since it seems almost impossible to silence all of them (we inherit docstrings from other projects like numpy, pandas, and matplotlib), and they only result in broken links.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   📚 New theme & rearrangement of the docs 790677360
772719625 https://github.com/pydata/xarray/pull/4835#issuecomment-772719625 https://api.github.com/repos/pydata/xarray/issues/4835 MDEyOklzc3VlQ29tbWVudDc3MjcxOTYyNQ== keewis 14808389 2021-02-03T18:22:08Z 2021-02-03T18:22:31Z MEMBER

that's because of the headings in whats-new.rst. I think you have to be consistent with the style you use (=, +, ~, -).

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   📚 New theme & rearrangement of the docs 790677360

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);