issue_comments

Table actions

6 rows where issue = 785573964 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 2

issue 1

  • ⚠️ Nightly upstream-dev CI failed ⚠️ · 6 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
762852212 https://github.com/pydata/xarray/issues/4807#issuecomment-762852212 https://api.github.com/repos/pydata/xarray/issues/4807 MDEyOklzc3VlQ29tbWVudDc2Mjg1MjIxMg== keewis 14808389 2021-01-19T13:52:22Z 2021-01-19T13:53:35Z MEMBER

that makes sense, I agree we don't really have to figure out what the actual cause was. If this pops up again we can just wait on the CI to open a new issue.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   ⚠️ Nightly upstream-dev CI failed ⚠️ 785573964
762722751 https://github.com/pydata/xarray/issues/4807#issuecomment-762722751 https://api.github.com/repos/pydata/xarray/issues/4807 MDEyOklzc3VlQ29tbWVudDc2MjcyMjc1MQ== mathause 10194086 2021-01-19T09:38:58Z 2021-01-19T09:38:58Z MEMBER

As it touches all backends my bet would be on numpy or pandas - maybe numpy/numpy#18152? I think it's not really worth digging - so I suggest to close this.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   ⚠️ Nightly upstream-dev CI failed ⚠️ 785573964
762535058 https://github.com/pydata/xarray/issues/4807#issuecomment-762535058 https://api.github.com/repos/pydata/xarray/issues/4807 MDEyOklzc3VlQ29tbWVudDc2MjUzNTA1OA== keewis 14808389 2021-01-19T00:53:52Z 2021-01-19T02:17:13Z MEMBER

interestingly, this didn't fail in the run yesterday. As far as I can tell, only the versions of identify, bottleneck, numpy, and pandas changed. Not sure if any of these could have fixed this. Maybe we did without noticing it?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   ⚠️ Nightly upstream-dev CI failed ⚠️ 785573964
760998226 https://github.com/pydata/xarray/issues/4807#issuecomment-760998226 https://api.github.com/repos/pydata/xarray/issues/4807 MDEyOklzc3VlQ29tbWVudDc2MDk5ODIyNg== mathause 10194086 2021-01-15T15:12:06Z 2021-01-15T15:12:06Z MEMBER

I guess the failure could easily be fixed - replace "abc" by b"abc" but the question is - why does this raise a NotImplementedError and still manage to write the file (for all backends)? When I try it locally I only get an empty netCDF.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   ⚠️ Nightly upstream-dev CI failed ⚠️ 785573964
760361443 https://github.com/pydata/xarray/issues/4807#issuecomment-760361443 https://api.github.com/repos/pydata/xarray/issues/4807 MDEyOklzc3VlQ29tbWVudDc2MDM2MTQ0Mw== keewis 14808389 2021-01-14T17:57:04Z 2021-01-14T17:57:04Z MEMBER

this is unrelated to #4759, the errors appeared before that (see https://github.com/pydata/xarray/runs/1684617075). The issue was opened today because the scheduled CI was broken until the merge of #4806.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   ⚠️ Nightly upstream-dev CI failed ⚠️ 785573964
760094155 https://github.com/pydata/xarray/issues/4807#issuecomment-760094155 https://api.github.com/repos/pydata/xarray/issues/4807 MDEyOklzc3VlQ29tbWVudDc2MDA5NDE1NQ== mathause 10194086 2021-01-14T10:06:54Z 2021-01-14T10:06:54Z MEMBER
  • I wonder if that has something to do with #4759. But why would this only fail upstream?
  • It is also similar to #4570 but h5py is still pinned...
  • Some of also seems to be correctly failing: we have encoding = {"dtype": "S1"} but expected has dtype U1.
  • The tests are enclosed with with pytest.raises(NotImplementedError): should these not fail if no error is raised? So why do we even get a result...
  • Why are some dask arrays not evaluated in assert_identical?
 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   ⚠️ Nightly upstream-dev CI failed ⚠️ 785573964

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);