issue_comments

Table actions

3 rows where issue = 784042442 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

user 3

issue 1

  • Use apply_ufunc for unary funcs · 3 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
824242833 https://github.com/pydata/xarray/issues/4796#issuecomment-824242833 https://api.github.com/repos/pydata/xarray/issues/4796 MDEyOklzc3VlQ29tbWVudDgyNDI0MjgzMw== max-sixty 5635139 2021-04-21T17:46:02Z 2021-04-21T17:47:45Z MEMBER

The specific case is closed by #5184, thanks to @dcherian for spotting.

Shall we change this issue into the general case highlighted by @keewis ?

Possibly _unary_op could do apply_ufunc in the same way that #5184 does? (But I haven't thought much about this — requires proper consideration)

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Use apply_ufunc for unary funcs 784042442
812868025 https://github.com/pydata/xarray/issues/4796#issuecomment-812868025 https://api.github.com/repos/pydata/xarray/issues/4796 MDEyOklzc3VlQ29tbWVudDgxMjg2ODAyNQ== keewis 14808389 2021-04-03T13:49:25Z 2021-04-03T13:49:25Z MEMBER

the issue is that we pass *args and **kwargs unmodified to dask, which obviously won't work (if isinstance(x.data, np.ndarray) == True it will be casted to numpy using asarray, which is why that succeeds).

I think this means that we should check for xarray objects in args / kwargs in {DataArray,Dataset,Variable}._unary_op and extract the data before calling f (which might be easier to implement if we stop injecting numpy methods).

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Use apply_ufunc for unary funcs 784042442
758563789 https://github.com/pydata/xarray/issues/4796#issuecomment-758563789 https://api.github.com/repos/pydata/xarray/issues/4796 MDEyOklzc3VlQ29tbWVudDc1ODU2Mzc4OQ== mathause 10194086 2021-01-12T10:32:39Z 2021-01-12T10:32:39Z MEMBER

x.clip(min=x.data) works so passing a DataArray is the problem. I am honestly not sure what we usually do - pass a DataArray or .data to the function.

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Use apply_ufunc for unary funcs 784042442

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);