issue_comments

Table actions

3 rows where issue = 780426518 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

author_association 2

issue 1

  • Always force dask arrays to float in missing.interp_func · 3 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
758773139 https://github.com/pydata/xarray/pull/4771#issuecomment-758773139 https://api.github.com/repos/pydata/xarray/issues/4771 MDEyOklzc3VlQ29tbWVudDc1ODc3MzEzOQ== Illviljan 14371165 2021-01-12T16:26:12Z 2021-01-12T16:26:12Z MEMBER

@mathause In the ideal world I think we should get back the same dtype as it was before interpolation. If we handle that with the same performance then it can be closed. Might be tough to close it though because when I've simply tested using .astype() it unfortunately slows down too much.

Maybe rewording the title a bit is in order or should we make a new one?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Always force dask arrays to float in missing.interp_func 780426518
758554850 https://github.com/pydata/xarray/pull/4771#issuecomment-758554850 https://api.github.com/repos/pydata/xarray/issues/4771 MDEyOklzc3VlQ29tbWVudDc1ODU1NDg1MA== mathause 10194086 2021-01-12T10:16:36Z 2021-01-12T10:16:36Z MEMBER

thanks @Illviljan! Do I understand correctly - this does not resolve #4770 and we should leave it open?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Always force dask arrays to float in missing.interp_func 780426518
755231273 https://github.com/pydata/xarray/pull/4771#issuecomment-755231273 https://api.github.com/repos/pydata/xarray/issues/4771 MDEyOklzc3VlQ29tbWVudDc1NTIzMTI3Mw== pep8speaks 24736507 2021-01-06T10:55:13Z 2021-01-06T12:04:04Z NONE

Hello @Illviljan! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! :beers:

Comment last updated at 2021-01-06 12:04:04 UTC
 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Always force dask arrays to float in missing.interp_func 780426518

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);