issue_comments

Table actions

6 rows where issue = 778123296 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

user 3

issue 1

  • Print number of variables in repr · 6 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
758308909 https://github.com/pydata/xarray/pull/4762#issuecomment-758308909 https://api.github.com/repos/pydata/xarray/issues/4762 MDEyOklzc3VlQ29tbWVudDc1ODMwODkwOQ== max-sixty 5635139 2021-01-12T00:21:28Z 2021-01-12T00:21:28Z MEMBER

Thanks @Illviljan !

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Print number of variables in repr 778123296
754713217 https://github.com/pydata/xarray/pull/4762#issuecomment-754713217 https://api.github.com/repos/pydata/xarray/issues/4762 MDEyOklzc3VlQ29tbWVudDc1NDcxMzIxNw== max-sixty 5635139 2021-01-05T15:38:28Z 2021-01-05T15:38:28Z MEMBER

LGTM, any final comments before we merge?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Print number of variables in repr 778123296
754135531 https://github.com/pydata/xarray/pull/4762#issuecomment-754135531 https://api.github.com/repos/pydata/xarray/issues/4762 MDEyOklzc3VlQ29tbWVudDc1NDEzNTUzMQ== max-sixty 5635139 2021-01-04T18:22:22Z 2021-01-04T18:22:22Z MEMBER

I've used pytest-regtest quite a lot, which is decent. It would be another dependency. For tests like this — where the output is easier to review than to create, these "expect" / "snapshot" / "regression" tests are ideal. If anyone wanted to swap out these tests for that, I would strongly support the effort.

An aside — I tried to make a similar tool that worked for inline results — https://github.com/max-sixty/pytest-accept. Unfortunately it's not possible to make it work with bare assert statements, without swapping out a lot of pytest's internals. For a while i worked a lot on https://github.com/mitsuhiko/insta, an excellent project, would be great to have the same thing in python.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Print number of variables in repr 778123296
754047005 https://github.com/pydata/xarray/pull/4762#issuecomment-754047005 https://api.github.com/repos/pydata/xarray/issues/4762 MDEyOklzc3VlQ29tbWVudDc1NDA0NzAwNQ== Illviljan 14371165 2021-01-04T15:38:32Z 2021-01-04T15:38:32Z MEMBER

I worked around it by only showing it when the repr is limited. That's the most important case anyway I think. 

{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Print number of variables in repr 778123296
754034361 https://github.com/pydata/xarray/pull/4762#issuecomment-754034361 https://api.github.com/repos/pydata/xarray/issues/4762 MDEyOklzc3VlQ29tbWVudDc1NDAzNDM2MQ== keewis 14808389 2021-01-04T15:16:00Z 2021-01-04T15:16:00Z MEMBER

unfortunately, I can't find a tool that does that. I guess either someone will have to write that tool or you will have to go through all the files and update by hand. For the latter, I would recommend to wait until the repr format has been reviewed so you don't have to do that more than once.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Print number of variables in repr 778123296
754005871 https://github.com/pydata/xarray/pull/4762#issuecomment-754005871 https://api.github.com/repos/pydata/xarray/issues/4762 MDEyOklzc3VlQ29tbWVudDc1NDAwNTg3MQ== Illviljan 14371165 2021-01-04T14:27:34Z 2021-01-04T14:27:34Z MEMBER

Ouch, forgot about the doctests... Going through them by hand is not happening. Is there any automatic way to do that?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Print number of variables in repr 778123296

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);