issue_comments

Table actions

8 rows where issue = 777526340 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

author_association 2

issue 1

  • Limit number of data rows shown in repr · 8 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
753682203 https://github.com/pydata/xarray/pull/4750#issuecomment-753682203 https://api.github.com/repos/pydata/xarray/issues/4750 MDEyOklzc3VlQ29tbWVudDc1MzY4MjIwMw== max-sixty 5635139 2021-01-03T22:00:40Z 2021-01-03T22:00:40Z MEMBER

Looks great! Any other comments from anyone before we merge?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Limit number of data rows shown in repr 777526340
753530682 https://github.com/pydata/xarray/pull/4750#issuecomment-753530682 https://api.github.com/repos/pydata/xarray/issues/4750 MDEyOklzc3VlQ29tbWVudDc1MzUzMDY4Mg== pep8speaks 24736507 2021-01-02T21:14:55Z 2021-01-03T21:55:05Z NONE

Hello @Illviljan! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! :beers:

Comment last updated at 2021-01-03 21:55:05 UTC
 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Limit number of data rows shown in repr 777526340
753679973 https://github.com/pydata/xarray/pull/4750#issuecomment-753679973 https://api.github.com/repos/pydata/xarray/issues/4750 MDEyOklzc3VlQ29tbWVudDc1MzY3OTk3Mw== max-sixty 5635139 2021-01-03T21:40:38Z 2021-01-03T21:40:38Z MEMBER

Re number of rows — no strong view — something between 12-20 seems great.

Would you like to add a whatsnew too?

Thanks!

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Limit number of data rows shown in repr 777526340
753679789 https://github.com/pydata/xarray/pull/4750#issuecomment-753679789 https://api.github.com/repos/pydata/xarray/issues/4750 MDEyOklzc3VlQ29tbWVudDc1MzY3OTc4OQ== max-sixty 5635139 2021-01-03T21:39:11Z 2021-01-03T21:39:11Z MEMBER

For black, you should be able to run black . in the root of the project, and black will format all the files.

A more integrated approach is to run pre-commit install and then either on every commit or pre-commit run will run all the checks.

You should also be able to integrate black with your editor, such that it makes the changes on every file save.

Let me know if you need any help with that, or the pre-commit docs are here: https://pre-commit.com/ — having to run it manually for each file doesn't sound like fun 😄 ! If it's unclear, then we should make our docs clearer — it's on us, not you.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Limit number of data rows shown in repr 777526340
753596176 https://github.com/pydata/xarray/pull/4750#issuecomment-753596176 https://api.github.com/repos/pydata/xarray/issues/4750 MDEyOklzc3VlQ29tbWVudDc1MzU5NjE3Ng== Illviljan 14371165 2021-01-03T10:26:39Z 2021-01-03T10:26:39Z MEMBER

I just do python import black black.main([f"{filename}"]) in my ipython console and that usually works. Does xarray have any further settings?

Any opinions on the default max_rows? It should be an even number so it divides cleanly with 2. I prefer 12 now because it leaves some room for a lot of coords as well.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Limit number of data rows shown in repr 777526340
753578756 https://github.com/pydata/xarray/pull/4750#issuecomment-753578756 https://api.github.com/repos/pydata/xarray/issues/4750 MDEyOklzc3VlQ29tbWVudDc1MzU3ODc1Ng== max-sixty 5635139 2021-01-03T07:14:49Z 2021-01-03T07:14:49Z MEMBER

Looks good!

I made the change on black (lmk if you need a hand setting that up client-side — ideally that should just work and make contributing easier not harder).

PRing a change so the black diff prints too

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Limit number of data rows shown in repr 777526340
753550006 https://github.com/pydata/xarray/pull/4750#issuecomment-753550006 https://api.github.com/repos/pydata/xarray/issues/4750 MDEyOklzc3VlQ29tbWVudDc1MzU1MDAwNg== Illviljan 14371165 2021-01-03T00:47:53Z 2021-01-03T00:47:53Z MEMBER

Added a test now and of course the code got a little heavier to handle the edge cases.

I don't really get why this black is complaining. I get no diffs on my version. It would be nice if it would show the changes so I can manually make it happy. Dask shows the black diffs for example.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Limit number of data rows shown in repr 777526340
753532879 https://github.com/pydata/xarray/pull/4750#issuecomment-753532879 https://api.github.com/repos/pydata/xarray/issues/4750 MDEyOklzc3VlQ29tbWVudDc1MzUzMjg3OQ== max-sixty 5635139 2021-01-02T21:37:27Z 2021-01-02T21:37:27Z MEMBER

Looks great! Could we add a test? We should already have done tests for reprs, so we can add a test case with enough lines for this to kick in.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Limit number of data rows shown in repr 777526340

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);