issue_comments

Table actions

22 rows where issue = 773945564 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

issue 1

  • Migrate CI from azure pipelines to GitHub Actions · 22 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
763228697 https://github.com/pydata/xarray/pull/4730#issuecomment-763228697 https://api.github.com/repos/pydata/xarray/issues/4730 MDEyOklzc3VlQ29tbWVudDc2MzIyODY5Nw== andersy005 13301940 2021-01-20T00:04:43Z 2021-01-20T00:04:43Z MEMBER

The "Overriding CI behaviors" is fairly prominent in the PR template, when I wouldn't expect it to be used that often. Was that intended? Should it be a markdown comment?

The current choice was just a first stab at documenting the CI "special" behaviors.

👍🏽 to making the "overriding CI behaviors" section a markdown comment and documenting this in the contributing guide (for convenience) if need be. 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Migrate CI from azure pipelines to GitHub Actions 773945564
763222558 https://github.com/pydata/xarray/pull/4730#issuecomment-763222558 https://api.github.com/repos/pydata/xarray/issues/4730 MDEyOklzc3VlQ29tbWVudDc2MzIyMjU1OA== max-sixty 5635139 2021-01-19T23:58:22Z 2021-01-19T23:58:22Z MEMBER

This seems to be going well, thanks again!

The "Overriding CI behaviors" is fairly prominent in the PR template, when I wouldn't expect it to be used that often. Was that intended? Should it be a markdown comment?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Migrate CI from azure pipelines to GitHub Actions 773945564
757912380 https://github.com/pydata/xarray/pull/4730#issuecomment-757912380 https://api.github.com/repos/pydata/xarray/issues/4730 MDEyOklzc3VlQ29tbWVudDc1NzkxMjM4MA== keewis 14808389 2021-01-11T12:10:59Z 2021-01-11T12:10:59Z MEMBER

Merging. If any issues remain we can fix them in new PRs.

 
{
    "total_count": 2,
    "+1": 2,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Migrate CI from azure pipelines to GitHub Actions 773945564
756424653 https://github.com/pydata/xarray/pull/4730#issuecomment-756424653 https://api.github.com/repos/pydata/xarray/issues/4730 MDEyOklzc3VlQ29tbWVudDc1NjQyNDY1Mw== keewis 14808389 2021-01-07T22:25:04Z 2021-01-07T22:57:54Z MEMBER

actually, we have a picture in the contributing docs which is really out-of-date now (there's still stickler and appveyor). Should we update that here, or is it fine to keep it until we rewrite the contributing docs (see #4361)?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Migrate CI from azure pipelines to GitHub Actions 773945564
756429533 https://github.com/pydata/xarray/pull/4730#issuecomment-756429533 https://api.github.com/repos/pydata/xarray/issues/4730 MDEyOklzc3VlQ29tbWVudDc1NjQyOTUzMw== dcherian 2448579 2021-01-07T22:35:43Z 2021-01-07T22:35:43Z MEMBER

Looks great. Thanks! I think we can wait to update the docs. 

{
    "total_count": 2,
    "+1": 2,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Migrate CI from azure pipelines to GitHub Actions 773945564
756310857 https://github.com/pydata/xarray/pull/4730#issuecomment-756310857 https://api.github.com/repos/pydata/xarray/issues/4730 MDEyOklzc3VlQ29tbWVudDc1NjMxMDg1Nw== andersy005 13301940 2021-01-07T18:53:48Z 2021-01-07T18:53:48Z MEMBER

Heres' what we get with [skip-ci] tag in the git commit message: Cc @dcherian 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Migrate CI from azure pipelines to GitHub Actions 773945564
756291965 https://github.com/pydata/xarray/pull/4730#issuecomment-756291965 https://api.github.com/repos/pydata/xarray/issues/4730 MDEyOklzc3VlQ29tbWVudDc1NjI5MTk2NQ== andersy005 13301940 2021-01-07T18:20:47Z 2021-01-07T18:20:47Z MEMBER

@andersy005 - I merged #4688, so we just have some conflicts to sort out now.

I'm working on it. Will update this branch shortly

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Migrate CI from azure pipelines to GitHub Actions 773945564
756289175 https://github.com/pydata/xarray/pull/4730#issuecomment-756289175 https://api.github.com/repos/pydata/xarray/issues/4730 MDEyOklzc3VlQ29tbWVudDc1NjI4OTE3NQ== jhamman 2443309 2021-01-07T18:16:21Z 2021-01-07T18:16:21Z MEMBER

@andersy005 - I merged #4688, so we just have some conflicts to sort out now. 

{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Migrate CI from azure pipelines to GitHub Actions 773945564
756253405 https://github.com/pydata/xarray/pull/4730#issuecomment-756253405 https://api.github.com/repos/pydata/xarray/issues/4730 MDEyOklzc3VlQ29tbWVudDc1NjI1MzQwNQ== keewis 14808389 2021-01-07T17:14:25Z 2021-01-07T17:14:25Z MEMBER

yes, this is for documentation-only commits. I would skip CI Additional and CI and keep linting, and ignore it for CI Upstream (see the discussion at https://github.com/pydata/xarray/pull/4729#discussion_r549794175).

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Migrate CI from azure pipelines to GitHub Actions 773945564
756248053 https://github.com/pydata/xarray/pull/4730#issuecomment-756248053 https://api.github.com/repos/pydata/xarray/issues/4730 MDEyOklzc3VlQ29tbWVudDc1NjI0ODA1Mw== andersy005 13301940 2021-01-07T17:06:54Z 2021-01-07T17:06:54Z MEMBER

should we do skip-ci in a different PR?

I can take care of this in this PR.

Please remind me... Is the objective here to disable all CIs when [skip-ci] is present in the git commit message?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Migrate CI from azure pipelines to GitHub Actions 773945564
756245479 https://github.com/pydata/xarray/pull/4730#issuecomment-756245479 https://api.github.com/repos/pydata/xarray/issues/4730 MDEyOklzc3VlQ29tbWVudDc1NjI0NTQ3OQ== keewis 14808389 2021-01-07T17:04:14Z 2021-01-07T17:04:14Z MEMBER

should we do skip-ci in a different PR?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Migrate CI from azure pipelines to GitHub Actions 773945564
756243970 https://github.com/pydata/xarray/pull/4730#issuecomment-756243970 https://api.github.com/repos/pydata/xarray/issues/4730 MDEyOklzc3VlQ29tbWVudDc1NjI0Mzk3MA== andersy005 13301940 2021-01-07T17:01:43Z 2021-01-07T17:01:43Z MEMBER

@andersy005 - what do you think about just removing 3.6 from the test matrix for now? #4720 will go in soon.

👍🏽 Makes sense.... Done!

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Migrate CI from azure pipelines to GitHub Actions 773945564
756235654 https://github.com/pydata/xarray/pull/4730#issuecomment-756235654 https://api.github.com/repos/pydata/xarray/issues/4730 MDEyOklzc3VlQ29tbWVudDc1NjIzNTY1NA== jhamman 2443309 2021-01-07T16:47:51Z 2021-01-07T16:47:51Z MEMBER

@andersy005 - what do you think about just removing 3.6 from the test matrix for now? #4720 will go in soon.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Migrate CI from azure pipelines to GitHub Actions 773945564
755832908 https://github.com/pydata/xarray/pull/4730#issuecomment-755832908 https://api.github.com/repos/pydata/xarray/issues/4730 MDEyOklzc3VlQ29tbWVudDc1NTgzMjkwOA== dcherian 2448579 2021-01-07T01:55:56Z 2021-01-07T01:55:56Z MEMBER

I think it's ok to ignore... 

{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Migrate CI from azure pipelines to GitHub Actions 773945564
755254195 https://github.com/pydata/xarray/pull/4730#issuecomment-755254195 https://api.github.com/repos/pydata/xarray/issues/4730 MDEyOklzc3VlQ29tbWVudDc1NTI1NDE5NQ== keewis 14808389 2021-01-06T11:46:52Z 2021-01-06T11:46:52Z MEMBER

win-py36 seems to consistently fail with some obscure "Windows fatal exception" error. Since we have #4720, should we care about this?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Migrate CI from azure pipelines to GitHub Actions 773945564
754967257 https://github.com/pydata/xarray/pull/4730#issuecomment-754967257 https://api.github.com/repos/pydata/xarray/issues/4730 MDEyOklzc3VlQ29tbWVudDc1NDk2NzI1Nw== max-sixty 5635139 2021-01-05T23:39:55Z 2021-01-05T23:39:55Z MEMBER

Very excited to get this in! Superb job!

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Migrate CI from azure pipelines to GitHub Actions 773945564
754960749 https://github.com/pydata/xarray/pull/4730#issuecomment-754960749 https://api.github.com/repos/pydata/xarray/issues/4730 MDEyOklzc3VlQ29tbWVudDc1NDk2MDc0OQ== keewis 14808389 2021-01-05T23:21:29Z 2021-01-05T23:21:29Z MEMBER

while we're at it: how about adding some of the hooks from pre-commit/pre-commit-hooks, like trailing-whitespace, end-of-file-fixer, check-docstring-first, and check-yaml? Can also be in a new PR.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Migrate CI from azure pipelines to GitHub Actions 773945564
754958057 https://github.com/pydata/xarray/pull/4730#issuecomment-754958057 https://api.github.com/repos/pydata/xarray/issues/4730 MDEyOklzc3VlQ29tbWVudDc1NDk1ODA1Nw== andersy005 13301940 2021-01-05T23:14:00Z 2021-01-05T23:18:48Z MEMBER

The pre-commit/action failure appears to be connected to https://github.com/pre-commit/action/issues/53. ~~I don't know how to address the issue yet...~~

Update: Restarting the workflow run fixes it 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Migrate CI from azure pipelines to GitHub Actions 773945564
750545072 https://github.com/pydata/xarray/pull/4730#issuecomment-750545072 https://api.github.com/repos/pydata/xarray/issues/4730 MDEyOklzc3VlQ29tbWVudDc1MDU0NTA3Mg== keewis 14808389 2020-12-23T23:15:37Z 2021-01-05T22:56:01Z MEMBER

I think the EOF issue is a bug in blackdoc, it shouldn't remove the newline immediately before EOF.

To fix the mypy errors I would change the hook configuration to exclude properties and asv_bench: yaml - repo: https://github.com/pre-commit/mirrors-mypy rev: v0.790 # Must match ci/requirements/*.yml hooks: - id: mypy exclude: "properties|asv_bench" if we do want to type check those we could add a empty __init__.py to properties and fix the errors in asv_bench

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Migrate CI from azure pipelines to GitHub Actions 773945564
754951477 https://github.com/pydata/xarray/pull/4730#issuecomment-754951477 https://api.github.com/repos/pydata/xarray/issues/4730 MDEyOklzc3VlQ29tbWVudDc1NDk1MTQ3Nw== keewis 14808389 2021-01-05T22:55:36Z 2021-01-05T22:55:36Z MEMBER

I just released blackdoc=0.3.2 (and updated .pre-commit-config.yaml in #4769), which fixes the issue mentioned in https://github.com/pydata/xarray/pull/4730#issuecomment-750545072.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Migrate CI from azure pipelines to GitHub Actions 773945564
753693790 https://github.com/pydata/xarray/pull/4730#issuecomment-753693790 https://api.github.com/repos/pydata/xarray/issues/4730 MDEyOklzc3VlQ29tbWVudDc1MzY5Mzc5MA== keewis 14808389 2021-01-03T23:42:58Z 2021-01-03T23:42:58Z MEMBER

from #4729: it might make sense to allow skipping the CI added here using a skip-ci or [skip-ci] in the commit subject line (the first line of the commit message).

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Migrate CI from azure pipelines to GitHub Actions 773945564
751945655 https://github.com/pydata/xarray/pull/4730#issuecomment-751945655 https://api.github.com/repos/pydata/xarray/issues/4730 MDEyOklzc3VlQ29tbWVudDc1MTk0NTY1NQ== jhamman 2443309 2020-12-29T04:52:10Z 2020-12-29T04:52:10Z MEMBER

Thanks @andersy005 for pulling this together. This will make for a much cleaner CI experience.

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Migrate CI from azure pipelines to GitHub Actions 773945564

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);