issue_comments

Table actions

3 rows where issue = 771198437 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

user 3

author_association 2

issue 1

  • Adding vectorized indexing docs · 3 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
780187888 https://github.com/pydata/xarray/pull/4711#issuecomment-780187888 https://api.github.com/repos/pydata/xarray/issues/4711 MDEyOklzc3VlQ29tbWVudDc4MDE4Nzg4OA== dcherian 2448579 2021-02-16T23:37:02Z 2021-02-16T23:37:02Z MEMBER

Looks great. Thanks @EricKeenan . I see this is your first PR, welcome to xarray!

 
{
    "total_count": 1,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 1,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Adding vectorized indexing docs 771198437
754905800 https://github.com/pydata/xarray/pull/4711#issuecomment-754905800 https://api.github.com/repos/pydata/xarray/issues/4711 MDEyOklzc3VlQ29tbWVudDc1NDkwNTgwMA== pep8speaks 24736507 2021-01-05T21:19:54Z 2021-02-16T22:28:41Z NONE

Hello @EricKeenan! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! :beers:

Comment last updated at 2021-02-16 22:28:41 UTC
 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Adding vectorized indexing docs 771198437
765039567 https://github.com/pydata/xarray/pull/4711#issuecomment-765039567 https://api.github.com/repos/pydata/xarray/issues/4711 MDEyOklzc3VlQ29tbWVudDc2NTAzOTU2Nw== keewis 14808389 2021-01-22T00:54:32Z 2021-01-22T00:54:32Z MEMBER

I would update the example in indexing.rst to use the dataset from the previous examples and maybe copy / adapt the examples to Dataset.sel / Dataset.isel (can be a new PR, though), but otherwise this looks good to me.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Adding vectorized indexing docs 771198437

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);