issue_comments

Table actions

4 rows where issue = 769288855 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

author_association 2

issue 1

  • Allow pathlib.Path to be passed to all engines · 4 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
910073725 https://github.com/pydata/xarray/pull/4701#issuecomment-910073725 https://api.github.com/repos/pydata/xarray/issues/4701 IC_kwDOAMm_X842Pp99 clbarnes 8995328 2021-09-01T08:46:35Z 2021-09-01T08:46:35Z NONE

Zarr's convenience methods accept Path objects as of 2.9.0: https://zarr.readthedocs.io/en/stable/release.html#enhancements

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Allow pathlib.Path to be passed to all engines 769288855
748274544 https://github.com/pydata/xarray/pull/4701#issuecomment-748274544 https://api.github.com/repos/pydata/xarray/issues/4701 MDEyOklzc3VlQ29tbWVudDc0ODI3NDU0NA== max-sixty 5635139 2020-12-18T19:19:18Z 2020-12-18T19:19:18Z MEMBER

Great! Thanks!

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Allow pathlib.Path to be passed to all engines 769288855
748001346 https://github.com/pydata/xarray/pull/4701#issuecomment-748001346 https://api.github.com/repos/pydata/xarray/issues/4701 MDEyOklzc3VlQ29tbWVudDc0ODAwMTM0Ng== alexamici 226037 2020-12-18T10:10:32Z 2020-12-18T10:10:32Z MEMBER

@max-sixty there's no direct test for the backend Store classes, only indirect tests through open_dataset. For example all other beckends do support pathlib.Path but none is tested.

Once we remove _normalize_path (PR is coming, and we may need a bit of discussion before approval) we will be able to test all backends.

I propose to merge this PR as it is.

 
{
    "total_count": 2,
    "+1": 2,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Allow pathlib.Path to be passed to all engines 769288855
747083109 https://github.com/pydata/xarray/pull/4701#issuecomment-747083109 https://api.github.com/repos/pydata/xarray/issues/4701 MDEyOklzc3VlQ29tbWVudDc0NzA4MzEwOQ== max-sixty 5635139 2020-12-16T22:39:01Z 2020-12-16T22:39:01Z MEMBER

LGTM @alexamici !

Could we add a small test / param onto an existing test? Or do you want to handle that as part of the larger PRs?

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Allow pathlib.Path to be passed to all engines 769288855

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);