issue_comments

Table actions

7 rows where issue = 767936284 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

author_association 3

issue 1

  • combine_by_coordinates to handle unnamed data arrays. · 7 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
873292175 https://github.com/pydata/xarray/pull/4696#issuecomment-873292175 https://api.github.com/repos/pydata/xarray/issues/4696 MDEyOklzc3VlQ29tbWVudDg3MzI5MjE3NQ== max-sixty 5635139 2021-07-02T22:53:06Z 2021-07-02T22:53:06Z MEMBER

Sorry @aijams ! Thank you for the reminder and forgive the delay. We appreciate the contribution (more than our responsiveness suggests!)

 
{
    "total_count": 1,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 1,
    "rocket": 0,
    "eyes": 0
}
   combine_by_coordinates to handle unnamed data arrays. 767936284
873275746 https://github.com/pydata/xarray/pull/4696#issuecomment-873275746 https://api.github.com/repos/pydata/xarray/issues/4696 MDEyOklzc3VlQ29tbWVudDg3MzI3NTc0Ng== github-actions[bot] 41898282 2021-07-02T21:58:59Z 2021-07-02T21:58:59Z CONTRIBUTOR

Unit Test Results

6 files  ±0           6 suites  ±0   47m 2s :stopwatch: ±0s 16 173 tests ±0  14 458 :heavy_check_mark: ±0  1 715 :zzz: ±0  0 :x: ±0  90 234 runs  ±0  82 130 :heavy_check_mark: ±0  8 104 :zzz: ±0  0 :x: ±0 

Results for commit 3d1d1342. ± Comparison against base commit 3d1d1342.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   combine_by_coordinates to handle unnamed data arrays. 767936284
873267680 https://github.com/pydata/xarray/pull/4696#issuecomment-873267680 https://api.github.com/repos/pydata/xarray/issues/4696 MDEyOklzc3VlQ29tbWVudDg3MzI2NzY4MA== TomNicholas 35968931 2021-07-02T21:34:20Z 2021-07-02T21:34:20Z MEMBER

Sorry @aijams ! I was following our broad rule of "two maintainers approve before merging", but this has sat here for absolutely ages and had feedback from others previously, so maybe I will just merge it now.

We really need a better system for catching PRs that just sit around :/

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   combine_by_coordinates to handle unnamed data arrays. 767936284
873252644 https://github.com/pydata/xarray/pull/4696#issuecomment-873252644 https://api.github.com/repos/pydata/xarray/issues/4696 MDEyOklzc3VlQ29tbWVudDg3MzI1MjY0NA== aijams 22328646 2021-07-02T20:56:57Z 2021-07-02T21:01:12Z CONTRIBUTOR

It looks like this PR has been neglected for a while. I haven't heard from a maintainer whether they will be merging in this PR any time soon. Edit: I just noticed that @TomNicholas plans on adding type hints to the two functions combine_nested and combine_by_coords changed in this PR.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   combine_by_coordinates to handle unnamed data arrays. 767936284
832281607 https://github.com/pydata/xarray/pull/4696#issuecomment-832281607 https://api.github.com/repos/pydata/xarray/issues/4696 MDEyOklzc3VlQ29tbWVudDgzMjI4MTYwNw== pep8speaks 24736507 2021-05-04T22:06:59Z 2021-06-10T16:15:56Z NONE

Hello @aijams! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! :beers:

Comment last updated at 2021-06-10 16:15:56 UTC
 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   combine_by_coordinates to handle unnamed data arrays. 767936284
846001851 https://github.com/pydata/xarray/pull/4696#issuecomment-846001851 https://api.github.com/repos/pydata/xarray/issues/4696 MDEyOklzc3VlQ29tbWVudDg0NjAwMTg1MQ== aijams 22328646 2021-05-21T14:43:34Z 2021-05-21T14:43:34Z CONTRIBUTOR

Sorry about the closing/reopening. I thought I was supposed to do something to get the code merged in to the official master. I accidentally pressed the wrong button thinking it did something else.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   combine_by_coordinates to handle unnamed data arrays. 767936284
837100080 https://github.com/pydata/xarray/pull/4696#issuecomment-837100080 https://api.github.com/repos/pydata/xarray/issues/4696 MDEyOklzc3VlQ29tbWVudDgzNzEwMDA4MA== dcherian 2448579 2021-05-10T18:27:11Z 2021-05-10T18:27:11Z MEMBER

@dcherian knows this so much better than me, so I'll let him take another look.

I defer to @TomNicholas =)

 
{
    "total_count": 2,
    "+1": 0,
    "-1": 0,
    "laugh": 1,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 1
}
   combine_by_coordinates to handle unnamed data arrays. 767936284

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);