issue_comments

Table actions

9 rows where issue = 766979952 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

author_association 2

issue 1

  • CI: run tests in parallel (pytest-xdist) · 9 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
747742696 https://github.com/pydata/xarray/pull/4694#issuecomment-747742696 https://api.github.com/repos/pydata/xarray/issues/4694 MDEyOklzc3VlQ29tbWVudDc0Nzc0MjY5Ng== mathause 10194086 2020-12-17T22:35:06Z 2020-12-17T22:35:06Z MEMBER

If it passes I am finished ;-)

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   CI: run tests in parallel (pytest-xdist) 766979952
747742542 https://github.com/pydata/xarray/pull/4694#issuecomment-747742542 https://api.github.com/repos/pydata/xarray/issues/4694 MDEyOklzc3VlQ29tbWVudDc0Nzc0MjU0Mg== dcherian 2448579 2020-12-17T22:34:43Z 2020-12-17T22:34:43Z MEMBER

sorry! didn't realize you were still working on it.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   CI: run tests in parallel (pytest-xdist) 766979952
744750919 https://github.com/pydata/xarray/pull/4694#issuecomment-744750919 https://api.github.com/repos/pydata/xarray/issues/4694 MDEyOklzc3VlQ29tbWVudDc0NDc1MDkxOQ== pep8speaks 24736507 2020-12-14T22:29:06Z 2020-12-17T22:33:42Z NONE

Hello @mathause! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! :beers:

Comment last updated at 2020-12-17 22:33:42 UTC
 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   CI: run tests in parallel (pytest-xdist) 766979952
747742024 https://github.com/pydata/xarray/pull/4694#issuecomment-747742024 https://api.github.com/repos/pydata/xarray/issues/4694 MDEyOklzc3VlQ29tbWVudDc0Nzc0MjAyNA== dcherian 2448579 2020-12-17T22:33:30Z 2020-12-17T22:33:30Z MEMBER

Great. Thanks @mathause this is a great improvement!

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   CI: run tests in parallel (pytest-xdist) 766979952
745310983 https://github.com/pydata/xarray/pull/4694#issuecomment-745310983 https://api.github.com/repos/pydata/xarray/issues/4694 MDEyOklzc3VlQ29tbWVudDc0NTMxMDk4Mw== dcherian 2448579 2020-12-15T14:14:06Z 2020-12-15T14:14:06Z MEMBER

I updated my previous comment. It looks like -n 4 saved us 5 minutes on windows and didn't affect the others.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   CI: run tests in parallel (pytest-xdist) 766979952
744788082 https://github.com/pydata/xarray/pull/4694#issuecomment-744788082 https://api.github.com/repos/pydata/xarray/issues/4694 MDEyOklzc3VlQ29tbWVudDc0NDc4ODA4Mg== dcherian 2448579 2020-12-14T23:20:56Z 2020-12-15T14:13:14Z MEMBER

Wow! Looks like a 30-40% improvement

(I'm not sure why the latest commit triggered two runs, but one of them has finished: https://dev.azure.com/xarray/xarray/_build?definitionId=1&_a=summary)

Before:

After -n 2

After -n 4

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   CI: run tests in parallel (pytest-xdist) 766979952
745288721 https://github.com/pydata/xarray/pull/4694#issuecomment-745288721 https://api.github.com/repos/pydata/xarray/issues/4694 MDEyOklzc3VlQ29tbWVudDc0NTI4ODcyMQ== mathause 10194086 2020-12-15T13:32:08Z 2020-12-15T13:32:08Z MEMBER

In the past, I've run into race conditions when using pytest-xdist for tests that required I/O tasks such as file downloading

It's not too difficult to remove the -n 4 and pytest-xdist again if we run into problems. It may, however, be more difficult to find out that random failures are due to race conditions...

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   CI: run tests in parallel (pytest-xdist) 766979952
744831125 https://github.com/pydata/xarray/pull/4694#issuecomment-744831125 https://api.github.com/repos/pydata/xarray/issues/4694 MDEyOklzc3VlQ29tbWVudDc0NDgzMTEyNQ== andersy005 13301940 2020-12-14T23:51:50Z 2020-12-14T23:51:50Z MEMBER

Nice! I think we get 2 hypter-threaded cores. So I can also try -n 4 and see if that helps. I wonder if there is any downside to this?

In the past, I've run into race conditions when using pytest-xdist for tests that required I/O tasks such as file downloading. So, it's likely everything will run fine with -n 4 provided we don't have tests with tasks that are likely to create race conditions. 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   CI: run tests in parallel (pytest-xdist) 766979952
744808574 https://github.com/pydata/xarray/pull/4694#issuecomment-744808574 https://api.github.com/repos/pydata/xarray/issues/4694 MDEyOklzc3VlQ29tbWVudDc0NDgwODU3NA== mathause 10194086 2020-12-14T23:35:27Z 2020-12-14T23:35:27Z MEMBER

Looks like a 30-40% improvement

Nice! I think we get 2 hypter-threaded cores. So I can also try -n 4 and see if that helps. I wonder if there is any downside to this?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   CI: run tests in parallel (pytest-xdist) 766979952

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);