issue_comments

Table actions

6 rows where issue = 753517739 and user = 14314623 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 1

  • jbusecke · 6 ✖

issue 1

  • Non lazy behavior for weighted average when using resampled data · 6 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
741811314 https://github.com/pydata/xarray/issues/4625#issuecomment-741811314 https://api.github.com/repos/pydata/xarray/issues/4625 MDEyOklzc3VlQ29tbWVudDc0MTgxMTMxNA== jbusecke 14314623 2020-12-09T14:34:45Z 2020-12-09T14:34:45Z CONTRIBUTOR

As @dcherian pointed out above copy(..., deep=False) does fix this for all cases I am testing.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Non lazy behavior for weighted average when using resampled data 753517739
741808410 https://github.com/pydata/xarray/issues/4625#issuecomment-741808410 https://api.github.com/repos/pydata/xarray/issues/4625 MDEyOklzc3VlQ29tbWVudDc0MTgwODQxMA== jbusecke 14314623 2020-12-09T14:30:57Z 2020-12-09T14:30:57Z CONTRIBUTOR

So I have added a test in #4668 and it confirms that this behavior is only occurring if the resample interval is smaller or equal than the chunks. If the resample interval is larger than the chunks it stays completely lazy...not sure if this is a general limitation? Does anyone have more insight into how resample handles this kind of workflow?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Non lazy behavior for weighted average when using resampled data 753517739
736880359 https://github.com/pydata/xarray/issues/4625#issuecomment-736880359 https://api.github.com/repos/pydata/xarray/issues/4625 MDEyOklzc3VlQ29tbWVudDczNjg4MDM1OQ== jbusecke 14314623 2020-12-01T23:15:19Z 2020-12-01T23:15:19Z CONTRIBUTOR

Oh I remember that too, and I didn't understand it at all...

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Non lazy behavior for weighted average when using resampled data 753517739
736563711 https://github.com/pydata/xarray/issues/4625#issuecomment-736563711 https://api.github.com/repos/pydata/xarray/issues/4625 MDEyOklzc3VlQ29tbWVudDczNjU2MzcxMQ== jbusecke 14314623 2020-12-01T13:50:21Z 2020-12-01T13:50:21Z CONTRIBUTOR

Do you have a suggestion how to test this? Should I write a test involving resample + weighted?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Non lazy behavior for weighted average when using resampled data 753517739
736147406 https://github.com/pydata/xarray/issues/4625#issuecomment-736147406 https://api.github.com/repos/pydata/xarray/issues/4625 MDEyOklzc3VlQ29tbWVudDczNjE0NzQwNg== jbusecke 14314623 2020-12-01T00:58:21Z 2020-12-01T00:58:21Z CONTRIBUTOR

Sweet. Ill try to apply this fix for my workflow now. Happy to submit a PR with the suggested changes to weighted.py too. 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Non lazy behavior for weighted average when using resampled data 753517739
736082255 https://github.com/pydata/xarray/issues/4625#issuecomment-736082255 https://api.github.com/repos/pydata/xarray/issues/4625 MDEyOklzc3VlQ29tbWVudDczNjA4MjI1NQ== jbusecke 14314623 2020-11-30T22:00:38Z 2020-11-30T22:00:38Z CONTRIBUTOR

Oh nooo. So would you suggest that in addition to #4559, we should have a kwarg to completely skip this?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Non lazy behavior for weighted average when using resampled data 753517739

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);