issue_comments

Table actions

4 rows where issue = 753097418 and user = 10194086 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: updated_at (date)

user 1

  • mathause · 4 ✖

issue 1

  • Add additional str accessor methods for DataArray · 4 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
797333372 https://github.com/pydata/xarray/pull/4622#issuecomment-797333372 https://api.github.com/repos/pydata/xarray/issues/4622 MDEyOklzc3VlQ29tbWVudDc5NzMzMzM3Mg== mathause 10194086 2021-03-12T08:44:00Z 2021-03-12T08:44:00Z MEMBER

Thanks - awesome! Even going through the code took ages so kudos for sticking with it!

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add additional str accessor methods for DataArray 753097418
750298452 https://github.com/pydata/xarray/pull/4622#issuecomment-750298452 https://api.github.com/repos/pydata/xarray/issues/4622 MDEyOklzc3VlQ29tbWVudDc1MDI5ODQ1Mg== mathause 10194086 2020-12-23T13:22:05Z 2020-12-23T13:22:05Z MEMBER

I opened an issue regarding the dtypes check. Let's see what the others think.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add additional str accessor methods for DataArray 753097418
749588453 https://github.com/pydata/xarray/pull/4622#issuecomment-749588453 https://api.github.com/repos/pydata/xarray/issues/4622 MDEyOklzc3VlQ29tbWVudDc0OTU4ODQ1Mw== mathause 10194086 2020-12-22T15:09:15Z 2020-12-22T15:09:15Z MEMBER

Sorry for the delay, I have been swamped at work. I probably won't have any time to work on this before Christmas.

No probem at all, just wanted to check in.

Yes you are correct concerning the dtype. This comes back to numpy, where the following returns true

python np.array("a") == np.array("a", dtype=object) I wonder if that's the right choice... Thus, you are right to change the tests.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add additional str accessor methods for DataArray 753097418
748853417 https://github.com/pydata/xarray/pull/4622#issuecomment-748853417 https://api.github.com/repos/pydata/xarray/issues/4622 MDEyOklzc3VlQ29tbWVudDc0ODg1MzQxNw== mathause 10194086 2020-12-21T08:52:04Z 2020-12-21T08:52:04Z MEMBER

Just wanted to let you know that we are definitively interested in this contribution! I'd start by removing the dtype assertions again, that makes the diff of the tests much smaller and more digestible. Unless there is a reason for them? Does this not work correctly in assert_equal?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add additional str accessor methods for DataArray 753097418

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);