issue_comments

Table actions

5 rows where issue = 742656246 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

author_association 2

issue 1

  • Match all float types in formatitem · 5 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
727640098 https://github.com/pydata/xarray/pull/4582#issuecomment-727640098 https://api.github.com/repos/pydata/xarray/issues/4582 MDEyOklzc3VlQ29tbWVudDcyNzY0MDA5OA== max-sixty 5635139 2020-11-15T21:29:57Z 2020-11-15T21:29:57Z MEMBER

Thanks @WardBrian ! 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Match all float types in formatitem 742656246
727279860 https://github.com/pydata/xarray/pull/4582#issuecomment-727279860 https://api.github.com/repos/pydata/xarray/issues/4582 MDEyOklzc3VlQ29tbWVudDcyNzI3OTg2MA== WardBrian 31640292 2020-11-14T23:23:33Z 2020-11-14T23:23:33Z CONTRIBUTOR

I've added test cases for the 3 main numpy floats (16, 32, and 64 bit). In particular they are testing the rounding behavior, which differs if they are matched in the elif clauses versus if they are just cast using str()

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Match all float types in formatitem 742656246
727063812 https://github.com/pydata/xarray/pull/4582#issuecomment-727063812 https://api.github.com/repos/pydata/xarray/issues/4582 MDEyOklzc3VlQ29tbWVudDcyNzA2MzgxMg== mathause 10194086 2020-11-13T22:19:18Z 2020-11-13T22:19:18Z MEMBER 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Match all float types in formatitem 742656246
727060864 https://github.com/pydata/xarray/pull/4582#issuecomment-727060864 https://api.github.com/repos/pydata/xarray/issues/4582 MDEyOklzc3VlQ29tbWVudDcyNzA2MDg2NA== max-sixty 5635139 2020-11-13T22:10:27Z 2020-11-13T22:10:27Z MEMBER

And welcome to xarray @WardBrian ! Great to have you as a contributor!

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Match all float types in formatitem 742656246
727060683 https://github.com/pydata/xarray/pull/4582#issuecomment-727060683 https://api.github.com/repos/pydata/xarray/issues/4582 MDEyOklzc3VlQ29tbWVudDcyNzA2MDY4Mw== max-sixty 5635139 2020-11-13T22:09:58Z 2020-11-13T22:09:58Z MEMBER

LGTM too. How would you feel about using an existing formatting test to test this?

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Match all float types in formatitem 742656246

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);