issue_comments

Table actions

10 rows where issue = 728782405 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

author_association 2

issue 1

  • Improve Dataset and DataArray docstrings · 10 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
717494320 https://github.com/pydata/xarray/pull/4532#issuecomment-717494320 https://api.github.com/repos/pydata/xarray/issues/4532 MDEyOklzc3VlQ29tbWVudDcxNzQ5NDMyMA== max-sixty 5635139 2020-10-27T19:48:50Z 2020-10-27T19:48:50Z MEMBER

Excellent PR @Illviljan ! Thank you. 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Improve Dataset and DataArray docstrings 728782405
715910031 https://github.com/pydata/xarray/pull/4532#issuecomment-715910031 https://api.github.com/repos/pydata/xarray/issues/4532 MDEyOklzc3VlQ29tbWVudDcxNTkxMDAzMQ== pep8speaks 24736507 2020-10-24T12:46:55Z 2020-10-27T19:47:46Z NONE

Hello @Illviljan! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! :beers:

Comment last updated at 2020-10-27 19:47:45 UTC
 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Improve Dataset and DataArray docstrings 728782405
716221826 https://github.com/pydata/xarray/pull/4532#issuecomment-716221826 https://api.github.com/repos/pydata/xarray/issues/4532 MDEyOklzc3VlQ29tbWVudDcxNjIyMTgyNg== keewis 14808389 2020-10-25T22:20:35Z 2020-10-25T22:20:35Z MEMBER

is that DataArray.units doesn't exist

it doesn't, but napoleon doesn't check whether the manually declared attributes actually exist. The issue is that the string Attributes: description: Ambient temperature. units: degC appears twice which makes napoleon with a enabled googledoc generate two Attributes sections. It is weird that description: doesn't trigger the same warning as units:, though.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Improve Dataset and DataArray docstrings 728782405
716219715 https://github.com/pydata/xarray/pull/4532#issuecomment-716219715 https://api.github.com/repos/pydata/xarray/issues/4532 MDEyOklzc3VlQ29tbWVudDcxNjIxOTcxNQ== max-sixty 5635139 2020-10-25T22:05:00Z 2020-10-25T22:05:00Z MEMBER

OK.

Tangentially — one weirdness is that DataArray.units doesn't exist, I think...

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Improve Dataset and DataArray docstrings 728782405
716218968 https://github.com/pydata/xarray/pull/4532#issuecomment-716218968 https://api.github.com/repos/pydata/xarray/issues/4532 MDEyOklzc3VlQ29tbWVudDcxNjIxODk2OA== keewis 14808389 2020-10-25T21:59:30Z 2020-10-25T21:59:30Z MEMBER

my guess is that Attributes: is picked up by the google-style parser, which is enabled by default. To fix that, we could try to explicitly enable numpydoc and disable the googledoc parser in conf.py: python napoleon_numpy_docstring = True napoleon_google_docstring = False

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Improve Dataset and DataArray docstrings 728782405
716216586 https://github.com/pydata/xarray/pull/4532#issuecomment-716216586 https://api.github.com/repos/pydata/xarray/issues/4532 MDEyOklzc3VlQ29tbWVudDcxNjIxNjU4Ng== max-sixty 5635139 2020-10-25T21:40:56Z 2020-10-25T21:40:56Z MEMBER

@Illviljan I moved the whatsnew to 0.16.2 — you should pull from your branch to get the changes. You don't need to do anything else.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Improve Dataset and DataArray docstrings 728782405
716212788 https://github.com/pydata/xarray/pull/4532#issuecomment-716212788 https://api.github.com/repos/pydata/xarray/issues/4532 MDEyOklzc3VlQ29tbWVudDcxNjIxMjc4OA== max-sixty 5635139 2020-10-25T21:12:46Z 2020-10-25T21:12:46Z MEMBER

Hmmm, nor do I.

@keewis might you recognize that error?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Improve Dataset and DataArray docstrings 728782405
716211610 https://github.com/pydata/xarray/pull/4532#issuecomment-716211610 https://api.github.com/repos/pydata/xarray/issues/4532 MDEyOklzc3VlQ29tbWVudDcxNjIxMTYxMA== Illviljan 14371165 2020-10-25T21:03:19Z 2020-10-25T21:03:19Z MEMBER

Yeah, I don't get this one. The dataset version didn't get this error for some reason

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Improve Dataset and DataArray docstrings 728782405
716209042 https://github.com/pydata/xarray/pull/4532#issuecomment-716209042 https://api.github.com/repos/pydata/xarray/issues/4532 MDEyOklzc3VlQ29tbWVudDcxNjIwOTA0Mg== max-sixty 5635139 2020-10-25T20:43:39Z 2020-10-25T20:43:39Z MEMBER

Docs are raising a warning: /home/docs/checkouts/readthedocs.org/user_builds/xray/checkouts/4532/xarray/core/dataarray.py:docstring of xarray.DataArray:121: WARNING: duplicate object description of xarray.DataArray.units, other instance in generated/xarray.DataArray, use :noindex: for one of them — lmk if you need a hand figuring it out.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Improve Dataset and DataArray docstrings 728782405
716207227 https://github.com/pydata/xarray/pull/4532#issuecomment-716207227 https://api.github.com/repos/pydata/xarray/issues/4532 MDEyOklzc3VlQ29tbWVudDcxNjIwNzIyNw== max-sixty 5635139 2020-10-25T20:30:22Z 2020-10-25T20:30:22Z MEMBER

Excellent @Illviljan !

Would you like to add a line under Documentation in the whatsnew, giving yourself credit? Then I'll merge

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Improve Dataset and DataArray docstrings 728782405

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);